[Bug 18357] New: On-site checkouts issues with 'Unlimited'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Bug ID: 18357 Summary: On-site checkouts issues with 'Unlimited' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When on-site checkouts are 'Unlimited' the checkouts can be blocked if there is a limit for checkouts in general To reproduce: Set All/All rule with Unlimited/unlimited for normal/onsite checkouts Will be able to perform onsite checkout Edit rule to be 15/Unlimited normal/onsite Will get error 'Too many: 1 on site checkout, only are allowed' Set rule to 15/15 Onsite checkouts work again Similar issue with Default checkout, hold and return policy and Default checkout limit by patron category -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18321 --- Comment #1 from Marc Véron <veron@veron.ch> --- Added Bug 18321 as related (problems with checkout count with onsite related sysprefs) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What wording do you suggest? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- I don't think the wording is the problem, it is the implementation - instead of being 'unlimited' the rules are applying as 0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68896&action=edit Bug 18357: Handle unlimited on-site checkouts If on-site checkouts are set to unlimited (i.e. NULL/undef), they are currently blocked. Test plan: 1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts 2/ Will be able to perform onsite checkout 3/ Edit rule to be 15/Unlimited normal/onsite 4/ Will be able to perform onsite checkout => Without this patch it was blocked 5/ Set rule to 15/15 6/ Onsite checkouts work again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14045 QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 [Bug 14045] Add specific quotas to on-site checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18321 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68896|0 |1 is obsolete| | --- Comment #5 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 68930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68930&action=edit Bug 18357: Handle unlimited on-site checkouts If on-site checkouts are set to unlimited (i.e. NULL/undef), they are currently blocked. Test plan: 1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts 2/ Will be able to perform onsite checkout 3/ Edit rule to be 15/Unlimited normal/onsite 4/ Will be able to perform onsite checkout => Without this patch it was blocked 5/ Set rule to 15/15 6/ Onsite checkouts work again Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68930|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 69129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69129&action=edit Bug 18357: Handle unlimited on-site checkouts If on-site checkouts are set to unlimited (i.e. NULL/undef), they are currently blocked. Test plan: 1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts 2/ Will be able to perform onsite checkout 3/ Edit rule to be 15/Unlimited normal/onsite 4/ Will be able to perform onsite checkout => Without this patch it was blocked 5/ Set rule to 15/15 6/ Onsite checkouts work again Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@bugs.koha-c |nick@bywatersolutions.com |ommunity.org | Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org