[Bug 23400] New: Add --status to koha-indexer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 Bug ID: 23400 Summary: Add --status to koha-indexer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: mirko@abunchofthings.net koha-zebra has a nice --status switch to say if zebra is running or not. We could add the same to koha-indexer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 93223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93223&action=edit Bug 23400 - Add --status to koha-indexer koha-zebra has a nice, informative --status switch, koha-indexer does not. This patch adds it. To test: - Run "sudo koha-indexer --status kohadev" - you get an error: "Error: invalid option switch (--status)" - Apply this patch - If you are on e.g. kohadevbox you need to copy koha-indexer to where it is actually run from: sudo cp debian/scripts/koha-indexer /usr/sbin/koha-indexer - Run "sudo koha-indexer --status kohadev" again and you should get a nice status telling if the indexer is running or not - Toggle the indexer on and off with koha-indexer --start/--stop and verify the status is telling the truth about the state of the indexer - Run "sudo koha-indexer --help" and check there is a description of the --status option - Have a look at debian/docs/koha-indexer.xml and verify there is an adequate description of the --status option. - Run "prove -v xt/verify-debian-docbook.t" to check the structure of the man page in DocBook format. PS: I tried to generate a manpage from the DocBook as described at https://wiki.koha-community.org/wiki/Testing_man_pages but the output did not look good for any of our DocBook files. Not sure why. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93223|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 93225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93225&action=edit Bug 23400 - Add --status to koha-indexer koha-zebra has a nice, informative --status switch, koha-indexer does not. This patch adds it. To test: - Run "sudo koha-indexer --status kohadev" - you get an error: "Error: invalid option switch (--status)" - Apply this patch - If you are on e.g. kohadevbox you need to copy koha-indexer to where it is actually run from: sudo cp debian/scripts/koha-indexer /usr/sbin/koha-indexer - Run "sudo koha-indexer --status kohadev" again and you should get a nice status telling if the indexer is running or not - Toggle the indexer on and off with koha-indexer --start/--stop and verify the status is telling the truth about the state of the indexer - Run "sudo koha-indexer --help" and check there is a description of the --status option - Have a look at debian/docs/koha-indexer.xml and verify there is an adequate description of the --status option. - Run "prove -v xt/verify-debian-docbook.t" to check the structure of the man page in DocBook format. PS: I tried to generate a manpage from the DocBook as described at https://wiki.koha-community.org/wiki/Testing_man_pages but the output did not look good for any of our DocBook files. Not sure why. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93225|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93724&action=edit Bug 23400 - Add --status to koha-indexer koha-zebra has a nice, informative --status switch, koha-indexer does not. This patch adds it. To test: - Run "sudo koha-indexer --status kohadev" - you get an error: "Error: invalid option switch (--status)" - Apply this patch - If you are on e.g. kohadevbox you need to copy koha-indexer to where it is actually run from: sudo cp debian/scripts/koha-indexer /usr/sbin/koha-indexer - Run "sudo koha-indexer --status kohadev" again and you should get a nice status telling if the indexer is running or not - Toggle the indexer on and off with koha-indexer --start/--stop and verify the status is telling the truth about the state of the indexer - Run "sudo koha-indexer --help" and check there is a description of the --status option - Have a look at debian/docs/koha-indexer.xml and verify there is an adequate description of the --status option. - Run "prove -v xt/verify-debian-docbook.t" to check the structure of the man page in DocBook format. PS: I tried to generate a manpage from the DocBook as described at https://wiki.koha-community.org/wiki/Testing_man_pages but the output did not look good for any of our DocBook files. Not sure why. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org