[Bug 22540] New: Add ability to place holds using SIP CLI emulator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Bug ID: 22540 Summary: Add ability to place holds using SIP CLI emulator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86748&action=edit Bug 22540 - Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> -m hold 2) Note the hold was placed in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86748|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86750&action=edit Bug 22540 - Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> -m hold 2) Note the hold was placed in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86750|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86751&action=edit Bug 22540 - Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> -m hold 2) Note the hold was placed in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Needs Signoff |Failed QA --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- The vars that didn't get declared aside (I fixed those ones) - this seems to create a string that the sip server sees as a disconnect, so doesn't quite work. It'll be really really good to have this in the emulator though. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc$ perl sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su=kohasip -sp=Koha1 -l LIB --item=TEST1111 --patron=23529000139858 -m hold Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNkohasip|COKoha1|CPLIB| READ: 941 Trying 'hold' SEND: 15+20190320 165132AOLIB|AA23529000139858|ABTEST1111|ACKoha1|BON| Use of uninitialized value $data in concatenation (.) or string at sip_cli_emulator.pl line 342, <GEN0> chunk 1. READ: Here is the result :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l LIB --item TEST1111 --patron 23529000139858 -m hold Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNkoha|COkoha|CPLIB| READ: 941 Trying 'hold' SEND: 15+20190320 165942AOLIB|AA23529000139858|ABTEST1111|ACkoha|BON| READ: 160N20190320 165944AA23529000139858|AOkohalibrary|AFNo such item.| Works when the item is missing ;) I'll dig deeper. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86825&action=edit Bug 22540: (QA Follow-up) borrowernumber is not an accessor for C4::SIP::ILS::Patron, access is via hashref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86826&action=edit Bug 22540: (QA Follow-up) Add ability to specify the pickup location using a command line parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86751|0 |1 is obsolete| | Attachment #86825|0 |1 is obsolete| | Attachment #86826|0 |1 is obsolete| | --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86827&action=edit Bug 22540: Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> --pickup-location <location_code> -m hold 2) Note the hold was placed in Koha Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22330 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86828&action=edit Bug 22540: (QA follow-up) fixes borrowernumber is not an accessor for C4::SIP::ILS::Patron, access is via hashref Add ability to specify the pickup location using a command line parameter Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22330 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86827|0 |1 is obsolete| | --- Comment #11 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91842&action=edit Bug 22540: Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> -m hold 2) Note the hold was placed in Koha Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22330 Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86828|0 |1 is obsolete| | --- Comment #12 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91843&action=edit Bug 22540: (QA follow-up) fixes borrowernumber is not an accessor for C4::SIP::ILS::Patron, access is via hashref Add ability to specify the pickup location using a command line parameter Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22330 Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91842|0 |1 is obsolete| | Attachment #91843|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93725&action=edit Bug 22540: Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> -m hold 2) Note the hold was placed in Koha Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22330 Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93726&action=edit Bug 22540: (QA follow-up) fixes borrowernumber is not an accessor for C4::SIP::ILS::Patron, access is via hashref Add ability to specify the pickup location using a command line parameter Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22330 Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org