[Bug 21663] New: Incorrect filter prevents predefined notes from being added to patron acccounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Bug ID: 21663 Summary: Incorrect filter prevents predefined notes from being added to patron acccounts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 13618 When viewing a patron-related page in the staff client one should be able to click the "Add message" button in the toolbar and select notes which have been defined in authorised_values category BOR_NOTES. In incorrect html filter at line 112 of members-toolbar.inc breaks this functionality. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81162&action=edit Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts This patch removes an "html" filter from the template include which allows one to add predefined nots to a patron's account. To test, apply the patch and open a patron record for viewing or checkout. Click the "Add message" button. The "predefined notes" dropdown should contain the authorised_values you have with the 'BOR_NOTES' category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81162|0 |1 is obsolete| | --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 81172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81172&action=edit Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts This patch removes an "html" filter from the template include which allows one to add predefined nots to a patron's account. To test, apply the patch and open a patron record for viewing or checkout. Click the "Add message" button. The "predefined notes" dropdown should contain the authorised_values you have with the 'BOR_NOTES' category. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81172|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81180&action=edit Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts This patch removes an "html" filter from the template include which allows one to add predefined nots to a patron's account. To test, apply the patch and open a patron record for viewing or checkout. Click the "Add message" button. The "predefined notes" dropdown should contain the authorised_values you have with the 'BOR_NOTES' category. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 [Bug 21669] TT assignment statements must not be html filtered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug not present in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Bug 21663 depends on bug 13618, which changed state. Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87275&action=edit Bug 21663: Add /patrons/{patron_id}/checkouts endpoint to REST API Test plan: 1) Apply the patch 2) Restart plack 3) Access GET to /patrons/{patron_id}/checkouts It should have the same abilities as /checkouts?patron_id={patron_id} 4) prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Attachment #87275|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 87275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87275 Bug 21663: Add /patrons/{patron_id}/checkouts endpoint to REST API Sorry, wrong bug number -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org