[Bug 19072] New: REST API: Toggle suspend for /api/v1/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Bug ID: 19072 Summary: REST API: Toggle suspend for /api/v1/holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@jns.fi QA Contact: testopia@bugs.koha-community.org Toggle suspend is missing from /api/v1/holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 65792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65792&action=edit Bug 19072: Toggle suspend for /api/v1/holds This patch adds ability to toggle suspend for a hold. To test: 1. prove t/db_dependent/api/v1/holds.t 2. Send a PUT request to suspended hold with suspend_until parameter as null 3. Observe that hold is now resumed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65792|0 |1 is obsolete| | --- Comment #2 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 65793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65793&action=edit Bug 19072: Toggle suspend for /api/v1/holds This patch adds ability to toggle suspend for a hold. To test: 1. prove t/db_dependent/api/v1/holds.t 2. Send a PUT request to suspended hold with suspend_until parameter as null 3. Observe that hold is now resumed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65793|0 |1 is obsolete| | --- Comment #3 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 65794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65794&action=edit Bug 19072: Toggle suspend for /api/v1/holds This patch adds ability to toggle suspend for a hold. To test: 1. prove t/db_dependent/api/v1/holds.t 2. Send a PUT request to suspended hold with suspend_until parameter as null 3. Observe that hold is now resumed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18137 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65794|0 |1 is obsolete| | --- Comment #4 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 65795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65795&action=edit Bug 19072: Toggle suspend for /api/v1/holds This patch adds ability to toggle suspend for a hold. To test: 1. prove t/db_dependent/api/v1/holds.t 2. Send a PUT request to suspended hold with suspend_until parameter as null 3. Observe that hold is now resumed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65795|0 |1 is obsolete| | --- Comment #5 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 65796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65796&action=edit Bug 19072: Toggle suspend for /api/v1/holds This patch adds ability to toggle suspend for a hold. To test: 1. prove t/db_dependent/api/v1/holds.t 2. Send a PUT request to suspended hold with suspend_until parameter as null 3. Observe that hold is now resumed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |benjamin.rokseth@kul.oslo.k | |ommune.no --- Comment #6 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- The use of C4::Reserves::ToggleSuspend is a bit counter-intuitive here. If you send a PUT to /api/v1/holds/x with '{"suspend":false}' it would suspend hold if it was not already suspended. I would rather respect the body request and suspend according to that, or you would have unpredictable results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org Component|Web services |REST api -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@jns.fi |ity.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Bug 19072 depends on bug 18137, which changed state. Bug 18137 Summary: REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |josef.moravec@gmail.com Resolution|--- |DUPLICATE --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- *** This bug has been marked as a duplicate of bug 22206 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org