[Bug 19119] New: Remove t/db_dependent/api/v1/swagger/definitions.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Bug ID: 19119 Summary: Remove t/db_dependent/api/v1/swagger/definitions.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org While it might have seemed a good idea to have such a test, I find it useless as-is, because there's no obvious reason why we would expose our model on the API spec while it is just user-facing and not a technical explanation on how we do things inside our codebase. A good example of this could be bug 18120, in which it is obvious that some attribute names are misleading or the attributes themselves need to be stripped out of the object for exposing on the API. There can be ways of doing this two operations (i.e. removing/adding attributes, and renaming) without handling it on the controller as those patches do. But in any case, there's no need for definitions.t. We could have a gentle 'warning' in the QA tools in case of a column being added to the DB structure and not to the corresponding endpoint, but it has to be a soft requirement IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67241&action=edit Bug 19119: Remove definitions.t This patch removes t/db_dependent/api/v1/swagger/definitions.t Its goal is not simple to achieve, and worth moving into the QA tools instead. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67241|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67267&action=edit Bug 19119: Remove definitions.t This patch removes t/db_dependent/api/v1/swagger/definitions.t Its goal is not simple to achieve, and worth moving into the QA tools instead. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Let remove it and see later if we need something else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18508 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 [Bug 18508] Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 18137) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Bug 19119 depends on bug 18508, which changed state. Bug 18508 Summary: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 18137) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org