https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 62817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62817&action=edit Bug 18508: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 18137) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18137 Status|NEW |Needs Signoff Assignee|chris@bigballofwax.co.nz |lari.taskula@jns.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Fought my way through the installing, applied 18137, and then this. Before application, failure. After application, success. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62818|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 62895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62895&action=edit Bug 18508: Add overdrive_auth_token to patron.json definition To test: 1. prove t/db_dependent/api/v1/swagger/definitions.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 --- Comment #7 from Lari Taskula <lari.taskula@jns.fi> --- (In reply to M. Tompsett from comment #4)

Fought my way through the installing, applied 18137, and then this. Before application, failure. After application, success.

Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |ldjamison@marywood.edu --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Lari Taskula from comment #0)

t/db_dependent/api/v1/swagger/definitions.t .. Can't locate object method "cache_dir" via package "Swagger2::SchemaValidator" at /usr/share/perl5/Swagger2.pm line 42.

For the record, I was able to also solve this by upgrading Swagger2 (cpan2deb'ing it). However, this patch is the recommended way according to the noise it generates when you only apply 18763, if I recall correctly. For what it's worth, I git bz'd 18508 and then 18763. I had to tweak the git bz, but basically both combined fix noise and test failures. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com |tomascohen@gmail.com Version|unspecified |master CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67232&action=edit Bug 18508: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 6758) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67266&action=edit Bug 18508: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 6758) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.