[Bug 18773] New: t/db_dependent/www/history.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Bug ID: 18773 Summary: t/db_dependent/www/history.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64168&action=edit Bug 18773: Fix failing history.t test changed get() to get_ok() and increased test count to match. Now the master build will only fail on search_utf8.t TEST PLAN --------- assuming KOHA_CONF is set. $ export KOHA_INTRANET_URL=... $ export KOHA_OPAC_URL=... $ prove -v t/db_dependent/www/history.t run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison@marywood.edu --- Comment #2 from Lee Jamison <ldjamison@marywood.edu> --- Applying the patch fixes the original problem with GETing the page. However, running prove -v t/db_dependant/www/history.t after patch application test 4 fails not ok 4 - Cyrillic characters with umlauts show correctly on the history page. # Failed test 'Cyrillic characters with umlauts show correctly on the history page.' # at t/db_dependent/www/history.t line 65. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Check the about.pl page -- The timeline is probably mostly blank. I replicated this problem on the kohadevbox. On an old school git install, the 4th test passes, because the history.txt file is found, and so is that translator's name. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Make sure /usr/share/doc/koha-common/history.txt (or some path similar to this) exists, if you find your the about.pl timeline tab mostly empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 --- Comment #5 from Lee Jamison <ldjamison@marywood.edu> --- (In reply to M. Tompsett from comment #4)
Make sure /usr/share/doc/koha-common/history.txt (or some path similar to this) exists, if you find your the about.pl timeline tab mostly empty.
Thank you for the advice! It turned out that there must have been a misconfiguration but after I ran reset_all in kohadevbox your patch works correctly after applying it so I will sign off on it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64168|0 |1 is obsolete| | --- Comment #6 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64174&action=edit [SIGNED OFF] Bug 18773: Fix failing history.t test changed get() to get_ok() and increased test count to match. Now the master build will only fail on search_utf8.t TEST PLAN --------- assuming KOHA_CONF is set. $ export KOHA_INTRANET_URL=... $ export KOHA_OPAC_URL=... $ prove -v t/db_dependent/www/history.t run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Works correctly using text plan provided and passes QA tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The tests pass for me, but the changes make sense (get only takes 1 parameter). It will certainly not fix Jenkins failures. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64174|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64200&action=edit Bug 18773: Fix failing history.t test changed get() to get_ok() and increased test count to match. Now the master build will only fail on search_utf8.t TEST PLAN --------- assuming KOHA_CONF is set. $ export KOHA_INTRANET_URL=... $ export KOHA_OPAC_URL=... $ prove -v t/db_dependent/www/history.t run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Works correctly using text plan provided and passes QA tools. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. Very excited to see those - hope they will turn Jenkins green! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org