[Bug 18411] New: t/db_dependent/www/search_utf8.t fails on 16.11.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Bug ID: 18411 Summary: t/db_dependent/www/search_utf8.t fails on 16.11.x Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: katrin.fischer@bsz-bw.de QA Contact: gmcharlt@gmail.com https://jenkins.koha-community.org/job/Koha_16.11.x_D8/lastCompletedBuild/te... perl t/db_dependent/www/history.t 1..2 ok 1 - Latin characters with umlauts show correctly on the history page. ok 2 - Cyrillic characters with umlauts show correctly on the history page. kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl t/db_dependent/www/search_utf8.t 1..66 ok 1 - connect to intranet ok 2 - login to staff client ok 3 - load main page ok 4 - open tools module Link not found at t/db_dependent/www/search_utf8.t line 127. # Looks like your test exited with 255 just after 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #1 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #0)
https://jenkins.koha-community.org/job/Koha_16.11.x_D8/lastCompletedBuild/ testReport/(root)/t_db_dependent_www_search_utf8_t/ Number_of_runned_tests_does_not_match_plan___668_/
perl t/db_dependent/www/history.t 1..2 ok 1 - Latin characters with umlauts show correctly on the history page. ok 2 - Cyrillic characters with umlauts show correctly on the history page. kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl t/db_dependent/www/search_utf8.t 1..66 ok 1 - connect to intranet ok 2 - login to staff client ok 3 - load main page ok 4 - open tools module Link not found at t/db_dependent/www/search_utf8.t line 127. # Looks like your test exited with 255 just after 4.
Hi, this also fails for me on master/7c8610c too mason@xen1:~/g/master$ sudo koha-shell -c 'prove ./t/db_dependent/www/search_utf8.t' mast3 ./t/db_dependent/www/search_utf8.t .. You tried to plan twice at ./t/db_dependent/www/search_utf8.t line 65. # Looks like your test exited with 255 before it could output anything. ./t/db_dependent/www/search_utf8.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 66/66 subtests Test Summary Report ------------------- ./t/db_dependent/www/search_utf8.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 66 tests but ran 0. Files=1, Tests=0, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.79 cusr 0.25 csys = 2.08 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Mason James from comment #1)
./t/db_dependent/www/search_utf8.t .. You tried to plan twice at
You did not specify KOHA_INTRANET_URL and KOHA_OPAC_URL % KOHA_INTRANET_URL=http://pro.kohadev.vm KOHA_OPAC_URL=http://catalogue.kohadev.vm prove t/db_dependent/www/search_utf8.t t/db_dependent/www/search_utf8.t .. ok All tests successful. Files=1, Tests=66, 67 wallclock secs ( 0.03 usr 0.00 sys + 1.44 cusr 0.76 csys = 2.23 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, ok, but how would we do this for Jenkins? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I get much more errors that Jenkins's ones. Someone else to take a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #4)
I get much more errors that Jenkins's ones. Someone else to take a look?
Ok pass for me locally finally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tomas, I get the following if I launch the tests manually on jenkins t/db_dependent/www/search_utf8.t .. 9/66 Error GETing http://koha_16_11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=7...: Bad Request at t/db_dependent/www/search_utf8.t line 170. But nothing in the logs to debug. Any ideas? I just see the apache access log which indeed returns a 400 koha_16_05:8080 127.0.0.1 - - [11/Apr/2017:20:54:24 +0000] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID=741d649f9d4472fe75f30761ba2488c0 HTTP/1.1" 400 0 "http://koha_16_11:8080/cgi-bin/koha/tools/stage-marc-import.pl" "Test-WWW-Mechanize/1.42" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Anything we can do here? Jenkins is still not happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #7)
Anything we can do here? Jenkins is still not happy.
Have a partial fix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64169&action=edit Bug 18411: Fix one test. TEST PLAN --------- export KOHA_INTRANET_URL=... prove -v t/db_dependent/www/search_utf8.t something like seen before failure: t/db_dependent/www/search_utf8.t .. 9/66 Error GETing http://koha_16_11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=7...: Bad Request at t/db_dependent/www/search_utf8.t line 170. apply this patch prove -v t/db_dependent/www/search_utf8.t Now it is the marc staging that is failing. And that is failing in master for me. So, I don't think it is the test that is a problem at this point, but the actual staged marc records process. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64169|0 |1 is obsolete| | --- Comment #10 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64172&action=edit [SIGNED OFF] Bug 18411: Fix one test. TEST PLAN --------- export KOHA_INTRANET_URL=... prove -v t/db_dependent/www/search_utf8.t something like seen before failure: t/db_dependent/www/search_utf8.t .. 9/66 Error GETing http://koha_16_11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=7...: Bad Request at t/db_dependent/www/search_utf8.t line 170. apply this patch prove -v t/db_dependent/www/search_utf8.t Now it is the marc staging that is failing. And that is failing in master for me. So, I don't think it is the test that is a problem at this point, but the actual staged marc records process. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> I'm not sure why you had problems. All 66 tests passed after patch application and the patch also passes QA Tools. I tested this patch on a brand new kohadevbox without issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master Summary|t/db_dependent/www/search_u |t/db_dependent/www/search_u |tf8.t fails on 16.11.x |tf8.t fails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The tests pass for me, but the changes make sense (get only takes 1 parameter). It will certainly not fix Jenkins failures. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64172|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64199&action=edit Bug 18411: Fix failing search_utf8.t tests TEST PLAN --------- export KOHA_INTRANET_URL=... prove -v t/db_dependent/www/search_utf8.t something like seen before failure: t/db_dependent/www/search_utf8.t .. 9/66 Error GETing http://koha_16_11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=7...: Bad Request at t/db_dependent/www/search_utf8.t line 170. apply this patch prove -v t/db_dependent/www/search_utf8.t Now it is the marc staging that is failing. And that is failing in master for me. So, I don't think it is the test that is a problem at this point, but the actual staged marc records process. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> I'm not sure why you had problems. All 66 tests passed after patch application and the patch also passes QA Tools. I tested this patch on a brand new kohadevbox without issue. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #11)
The tests pass for me, but the changes make sense (get only takes 1 parameter). It will certainly not fix Jenkins failures.
True, but as I said in comment #8 -- it's a partial fix. If someone could track down why it is failing for me, and not Lee, then we would have Jenkins fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org