[Bug 35450] New: Punctuation: Preservation system preferences should end with a .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Bug ID: 35450 Summary: Punctuation: Preservation system preferences should end with a . Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I noticed that the new preservation system preferences are missing the ending . at the end of the sentences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... these also should be pull downs with the values (like we do for lost now) instead of input fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Punctuation: Preservation |Preservation system |system preferences should |preferences should authval |end with a . |dropdowns Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159463&action=edit Bug 35450: Preservation system preferences should authval dropdowns This patch updates two preservation module system preferences so that they offer dropdowns of "Not for loan" values instead of requiring entry of a specific code. The patch also adds a missing "." at the end of one preference description. To test, apply the patch and restart services. - Go to Administration -> System preferences. - Search for "preservation" - Check that the "PreservationNotForLoanDefaultTrainIn" and "PreservationNotForLoanWaitingListIn" preferences have dropdowns offering "Not for loan" values. - Confirm that your choices are correctly saved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159463|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159482&action=edit Bug 35450: Preservation system preferences should authval dropdowns This patch updates two preservation module system preferences so that they offer dropdowns of "Not for loan" values instead of requiring entry of a specific code. The patch also adds a missing "." at the end of one preference description. To test, apply the patch and restart services. - Go to Administration -> System preferences. - Search for "preservation" - Check that the "PreservationNotForLoanDefaultTrainIn" and "PreservationNotForLoanWaitingListIn" preferences have dropdowns offering "Not for loan" values. - Confirm that your choices are correctly saved. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159482|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159666&action=edit Bug 35450: Preservation system preferences should authval dropdowns This patch updates two preservation module system preferences so that they offer dropdowns of "Not for loan" values instead of requiring entry of a specific code. The patch also adds a missing "." at the end of one preference description. To test, apply the patch and restart services. - Go to Administration -> System preferences. - Search for "preservation" - Check that the "PreservationNotForLoanDefaultTrainIn" and "PreservationNotForLoanWaitingListIn" preferences have dropdowns offering "Not for loan" values. - Confirm that your choices are correctly saved. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Status|Signed Off |Passed QA CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Good catch, it was possible to save any value in the syspref 💥 :o Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Preservation system |Preservation system |preferences should authval |preferences should be |dropdowns |authorised value pull downs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed in 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org