https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 [Bug 26050] [OMNIBUS] Convert system preferences to news block -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27451 CC| |josef.moravec@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27451 [Bug 27451] Split opac_news.lang into two distinct fields for location and language -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_21_11_candidate --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can we rush this for 21.11? :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127360&action=edit Bug 24224: Convert OpacNavBottom system preference to additional content This patch builds on Bug 22318 to move the OpacNavBottom system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNavBottom system preference. To make testing easier it's also a good idea to have content in the OpacNav preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNavBottom is now stored there. When you edit the entry you should see content from the OpacNavBottom system preference under the "default" tab. - The publication date for the entry should be today's date. - Confirm that the previous contents of OpacNavBottom were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavBottom preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNavBottom system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNavBottom is also displayed. - Test also using the updated translation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127360|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127363&action=edit Bug 24224: Convert OpacNavBottom system preference to additional content This patch builds on Bug 22318 to move the OpacNavBottom system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNavBottom system preference. To make testing easier it's also a good idea to have content in the OpacNav preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNavBottom is now stored there. When you edit the entry you should see content from the OpacNavBottom system preference under the "default" tab. - The publication date for the entry should be today's date. - Confirm that the previous contents of OpacNavBottom were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavBottom preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNavBottom system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNavBottom is also displayed. - Test also using the updated translation. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #4)

This looks great.. signing off.

One query..

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt

That adds OpacNav too here.. shouldn't that have been caught in the dependency bug already?

Yes, line will be moved on push. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Bug 24224 depends on bug 24223, which changed state. Bug 24223 Summary: Convert OpacNav system preference to news block https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.