[Bug 29430] New: Table cell click doesn't activate buttons in patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Bug ID: 29430 Summary: Table cell click doesn't activate buttons in patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 15812 In patron search results, if you check one or more checkboxes it changes the state of the "Add to patron list" and "Merge patrons" buttons. The same doesn't happen if you click the table cell. When JS was added to allow a click of the table cell to toggle the checkbox inside it didn't take into account the change function which would need to be triggered. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127401&action=edit Bug 29430: Table cell click doesn't activate buttons in patron search Bug 15812 included a change which allows a click on the patron search results table cell to toggle the checkbox it contains. This patch modifies that click event so that it fires the change() event which is required for toggling the "Add to patron list" and "Merge patrons" buttons. To reproduce this problem, perform a patron search in the staff client which will return multiple results. - In the first column containing checkboxes, click in the empty part of the table cell. The checkbox should be checked. - However, the "Add to patron list" button remains disabled. - Clicking a table cell to check another checkbox should result in the "Merge selected patrons" button being enabled, but it doesn't. To test, apply the patch and repeat the process above. The behavior of the buttons should be the same whether you're clicking the checkbox itself or the table cell it's in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127401|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 127407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127407&action=edit Bug 29430: Table cell click doesn't activate buttons in patron search Bug 15812 included a change which allows a click on the patron search results table cell to toggle the checkbox it contains. This patch modifies that click event so that it fires the change() event which is required for toggling the "Add to patron list" and "Merge patrons" buttons. To reproduce this problem, perform a patron search in the staff client which will return multiple results. - In the first column containing checkboxes, click in the empty part of the table cell. The checkbox should be checked. - However, the "Add to patron list" button remains disabled. - Clicking a table cell to check another checkbox should result in the "Merge selected patrons" button being enabled, but it doesn't. To test, apply the patch and repeat the process above. The behavior of the buttons should be the same whether you're clicking the checkbox itself or the table cell it's in. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127407|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127412&action=edit Bug 29430: Table cell click doesn't activate buttons in patron search Bug 15812 included a change which allows a click on the patron search results table cell to toggle the checkbox it contains. This patch modifies that click event so that it fires the change() event which is required for toggling the "Add to patron list" and "Merge patrons" buttons. To reproduce this problem, perform a patron search in the staff client which will return multiple results. - In the first column containing checkboxes, click in the empty part of the table cell. The checkbox should be checked. - However, the "Add to patron list" button remains disabled. - Clicking a table cell to check another checkbox should result in the "Merge selected patrons" button being enabled, but it doesn't. To test, apply the patch and repeat the process above. The behavior of the buttons should be the same whether you're clicking the checkbox itself or the table cell it's in. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org