[Bug 5203] New: Creating a label template causes fatal error if description field is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5203 Summary: Creating a label template causes fatal error if description field is empty Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Label printing AssignedTo: cnighswonger@foundations.edu ReportedBy: wizzyrea@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Attempting to save a label template causes a fatal error Software error: Can't call method "save" without a package or object reference at /home/liz/kohaclone/labels/label-edit-template.pl line 102. For help, please send mail to the webmaster (webmaster@koha-deb), giving this error message and the time and date of the error. when the default text is removed and no text is typed into the description field (it's empty). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5203 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Estimated Hours|0.0 |1.0 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5203 --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-09-23 17:52:14 UTC --- *** Bug 5238 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5203 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #2 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-09-23 17:57:16 UTC --- This is due to the underlying script not having any defaults hard coded which results in skewed hash elements when the parameter array is coerced into a hash at a later point. This also occurs in layouts and profiles. This patch adds defaults to all three. No documentation changes are necessary. The patch is available here: http://git.koha-community.org/gitweb/?p=wip/koha-fbc.git;a=shortlog;h=refs/h... Please test, sign-off, and submit to patches@... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5203 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Hours Worked| |.5 --- Comment #3 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-09-23 17:57:51 UTC --- Updating time. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5203 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5203 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2010-12-16 16:57:42 UTC --- has this patch been pushed? When I try (Before applying the patch) I can't clear out the description at all. I get no error, but if I save with an empty description it puts the 'default description' in again. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5203 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |magnus@enger.priv.no Patch Status|Needs Signoff |Patch Pushed Resolution| |FIXED --- Comment #5 from Magnus Enger <magnus@enger.priv.no> 2011-06-04 18:21:55 UTC --- I can confirm Nicole's observation - it looks like the changes proposed by Chris N. have made it into Koha, based on a comparison of these: http://git.koha-community.org/gitweb/?p=wip/koha-fbc.git;a=blob;f=labels/lab... and http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=labels/label-edit-... http://git.koha-community.org/gitweb/?p=wip/koha-fbc.git;a=blobdiff;f=labels... and http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=labels/label-edit-... http://git.koha-community.org/gitweb/?p=wip/koha-fbc.git;a=blobdiff;f=labels... and http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=labels/label-edit-... Saving a template with an empty description gives it the description "Default description". Marking as "patch pushed" and fixed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org