[Bug 6436] New: Don't allow deletion of an itemtype used in items.itype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6436 Bug #: 6436 Summary: Don't allow deletion of an itemtype used in items.itype Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: System Administration AssignedTo: paul.poulain@biblibre.com ReportedBy: fridolyn.somers@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com When trying to delete an item type, the code checks if its code is used in biblioitems.itemtype and if it is, deosn't allow suppression. But item type can also be in items.itype. I modified code to check both locations. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6436 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-31 13:33:02 UTC --- Created attachment 4319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4319 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6436 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4319|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-05-31 20:16:04 UTC --- Created attachment 4321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4321 Signed-off patch With the patch applied I am prevented from deleting an item type if it is in use in the biblio record or the item record. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Needs Signoff |Signed Off AssignedTo|paul.poulain@biblibre.com |fridolyn.somers@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6436 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-06-01 07:38:57 UTC --- (In reply to comment #2)
Created attachment 4321 [details] Signed-off patch
With the patch applied I am prevented from deleting an item type if it is in use in the biblio record or the item record.
Thanks, this is an important bug I think. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6436 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-06-03 02:26:55 UTC --- Pushed to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6436 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-06-06 11:48:06 UTC --- Tested : Create a new item type Use it in an item => impossible to delete Remove it from the item => delete with confirmation ok Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6436 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org