[Bug 7878] New: When duplicating a patron too many fields carrying over
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Priority: P5 - low Change sponsored?: --- Bug ID: 7878 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: When duplicating a patron too many fields carrying over QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha When duplicating the patron in the top section only the Surname should carry over - right now the other name and initials carry over. Along the same lines at the bottom the expiration date is coming over and that could be different based on when you're doing the duplication and your patron category rules. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Christopher <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher <cbrannon@cdalibrary.org> --- I see that gender, OPAC & Staff notes, and restrictions also carry over. I have confirmed all the Nicole has mentioned, and agree that copying the expiration is a problem. Christopher Brannon -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|kyle.m.hall@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31903&action=edit Bug 7878 - When duplicating a patron too many fields carrying over When duplicating a patron the resulting entry form contains the data from the original patron in the following fields: Other names, Initials, Gender, OPAC note, Staff note, and expiration date. These should be blank for a new duplicated patron. This patch corrects this. To test, locate or create a patron record which contains data in the fields listed above. Duplicate that patron and confirm that those fields are blank in the resulting patron entry form. Confirm also that editing an existing patron with data in those fields works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31903|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 32001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32001&action=edit [SIGNED OFF] Bug 7878 - When duplicating a patron too many fields carrying over When duplicating a patron the resulting entry form contains the data from the original patron in the following fields: Other names, Initials, Gender, OPAC note, Staff note, and expiration date. These should be blank for a new duplicated patron. This patch corrects this. To test, locate or create a patron record which contains data in the fields listed above. Duplicate that patron and confirm that those fields are blank in the resulting patron entry form. Confirm also that editing an existing patron with data in those fields works correctly. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Is there a reason not to use UNLESS instead of "IF do nothing ELSE do something"? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #4)
Is there a reason not to use UNLESS instead of "IF do nothing ELSE do something"?
Probably not, just following the pattern already established in the template. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32001|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32234&action=edit Bug 7878 - When duplicating a patron too many fields carrying over When duplicating a patron the resulting entry form contains the data from the original patron in the following fields: Other names, Initials, Gender, OPAC note, Staff note, and expiration date. These should be blank for a new duplicated patron. This patch corrects this. To test, locate or create a patron record which contains data in the fields listed above. Duplicate that patron and confirm that those fields are blank in the resulting patron entry form. Confirm also that editing an existing patron with data in those fields works correctly. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32235&action=edit Bug 7878: (qa follow-up) Fix the sex default value Without the previous patch, when you edited a patron, the "N/A" value was selected for sex. With, no checkboxes were selected. This patch also replaces the IF opduplicate do nothing ELSE do something END statement with UNLESS opduplicate do something END which is more readable. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7878 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org