[Bug 13199] New: Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bug ID: 13199 Summary: Incoherence between 'en' sample notices and translated notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: frederic@tamil.fr QA Contact: gmcharlt@gmail.com Koha sample notices are loaded to 'letter' table from a text SQL file during Koha installation by web installer. The reference file is the one provided for English (en) installation : <koha_root>/installer/data/mysql/en/mandatory/sample_notices.sql Alternatives files are provided for other languages. Those files are difficult to keep synchronized with reference file. This could be an functional issue since some Koha operation depend on notice existence, for example Print Slip in Circulation. For example, for French installation, those notices are missing: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33216&action=edit Bug 13199 Add missing notices for fr-FR installation prove xt/sample_notices.sql identifies five missing notices for fr-FR. This patch add those missing notices: ISSUEQSLIP ISSUESLIP OPAC_REG_VERIFY RESERVESLIP TRANSFERSLIP -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33217&action=edit Bug 13199 Test incoherence between 'en' sample notices and translated notices This test identifies incoherences between translated sample notices and the 'en' reference file. Koha sample notices are loaded to 'letter' table from a text SQL file during Koha installation by web installer. The reference file is the one provided for English (en) installation : <koha_root>/installer/data/mysql/en/mandatory/sample_notices.sql Alternatives files are provided for other languages. Those files are difficult to keep synchronized with reference file. This could be an functional issue since some Koha operation depend on notice existence, for example Print Slip in Circulation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- The test identifies other missing notices: - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Katrin: I've added you to this patch CC! You're in best position to confirm this bug may be disturbing/blocking for non-English installations, since you're the only one to succeed having a de-DE on a par with 'en' sample notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Frederic, hopefully those will be the last inconsistencies to be cleaned up. I'd like to have the test, but it will need to pass. - Could you also provide a patch for ru-RU and uk-UA? Copying the English samples is fine - still a good help to get people started making their own translated notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Component|Test Suite |Installation and upgrade | |(web-based installer) QA Contact|gmcharlt@gmail.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> ---
Could you also provide a patch for ru-RU and uk-UA? Copying the English samples is fine - still a good help to get people started making their own translated notices.
Ok. Will do this evening. Do you have someone doing it-I & pl-PL? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah sorry, I missed those in the test output. If you could do them all that would be great. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it --- Comment #8 from Zeno Tajoli <z.tajoli@cineca.it> --- For OPAC_REG_VERIFY, RENEWAL in it-IT/necessari/notices.sql the English strings are OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33216|0 |1 is obsolete| | --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33336&action=edit Bug 13199 Add missing notices for several installations prove xt/sample_notices.sql identifies missing notices. This patch add those missing notices: - fr-FR ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP TO TEST: (1) Without this patch, but with the patch adding xt/sample_notices.sql: prove xt/sample_notices.sql list all the above missing notices. (2) Apply this patch. And do prove again: nothing is reported. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33217|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 33352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33352&action=edit [SIGNED-OFF] Bug 13199: Test incoherence between 'en' sample notices and translated notices This test identifies incoherences between translated sample notices and the 'en' reference file. Koha sample notices are loaded to 'letter' table from a text SQL file during Koha installation by web installer. The reference file is the one provided for English (en) installation : <koha_root>/installer/data/mysql/en/mandatory/sample_notices.sql Alternatives files are provided for other languages. Those files are difficult to keep synchronized with reference file. This could be an functional issue since some Koha operation depend on notice existence, for example Print Slip in Circulation. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test works and identify missing notices A few koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33336|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 33353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33353&action=edit [SIGNED-OFF] Bug 13199: Add missing notices for several installations prove xt/sample_notices.sql identifies missing notices. This patch add those missing notices: - fr-FR ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP TO TEST: (1) Without this patch, but with the patch adding xt/sample_notices.sql: prove xt/sample_notices.sql list all the above missing notices. (2) Apply this patch. And do prove again: nothing is reported. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, test stop failing No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 33354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33354&action=edit Bug 13199: follow up to fix Licence and some koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33353|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33359&action=edit [PASSED QA] Bug 13199: Test incoherence between 'en' sample notices and translated notices This test identifies incoherences between translated sample notices and the 'en' reference file. Koha sample notices are loaded to 'letter' table from a text SQL file during Koha installation by web installer. The reference file is the one provided for English (en) installation : <koha_root>/installer/data/mysql/en/mandatory/sample_notices.sql Alternatives files are provided for other languages. Those files are difficult to keep synchronized with reference file. This could be an functional issue since some Koha operation depend on notice existence, for example Print Slip in Circulation. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test works and identify missing notices A few koha-qa errors fixed in followup Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33360&action=edit [PASSED QA] Bug 13199: Add missing notices for several installations prove xt/sample_notices.sql identifies missing notices. This patch add those missing notices: - fr-FR ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP TO TEST: (1) Without this patch, but with the patch adding xt/sample_notices.sql: prove xt/sample_notices.sql list all the above missing notices. (2) Apply this patch. And do prove again: nothing is reported. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, test stop failing No koha-qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33361&action=edit [PASSED QA] Bug 13199: follow up to fix Licence and some koha-qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Frederic and Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Frederic and Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org