[Bug 41560] New: Useless (and confusing) id attribute on a couple of script tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 Bug ID: 41560 Summary: Useless (and confusing) id attribute on a couple of script tag Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt have <script id="js"> That's not needed, useless, and confusing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191060&action=edit Bug 41560: Remove id="js" from script tags Both files koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt have <script id="js"> That's not needed, useless, and confusing. Added from those commits for no obvious reasons catalogue/issuehistory.tt commit df98c8aaaaf0a7406dc24f4c288c8f930aa8215d CommitDate: Mon May 14 15:39:44 2012 +0200 bug_7647: Table sorter on issue history members/readingrec.tt commit 77b6409802e6ce5612883ec6d22db9545547444a CommitDate: Mon Mar 21 20:02:15 2011 +1300 Bug 5917 : Converted templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 [Bug 41566] Tidy kohaTable block - catalogue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41572 [Bug 41572] Tidy kohaTable block - members -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191060|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 191229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191229&action=edit Bug 41560: Remove id="js" from script tags Both files koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt have <script id="js"> That's not needed, useless, and confusing. Added from those commits for no obvious reasons catalogue/issuehistory.tt commit df98c8aaaaf0a7406dc24f4c288c8f930aa8215d CommitDate: Mon May 14 15:39:44 2012 +0200 bug_7647: Table sorter on issue history members/readingrec.tt commit 77b6409802e6ce5612883ec6d22db9545547444a CommitDate: Mon Mar 21 20:02:15 2011 +1300 Bug 5917 : Converted templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. I accessed the changed pages before and after the patch. There were no JavaScript errors and the pages worked as expected. 1. Check out two items to a patron and then check in one of the items. 2. From the record's page in the staff interface, view the 'Checkout history' page. 3. From the patron's record in the staff interface, view the 'Circulation history' page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191229|0 |1 is obsolete| | --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 191967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191967&action=edit Bug 41560: Remove id="js" from script tags Both files koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt have <script id="js"> That's not needed, useless, and confusing. Added from those commits for no obvious reasons catalogue/issuehistory.tt commit df98c8aaaaf0a7406dc24f4c288c8f930aa8215d CommitDate: Mon May 14 15:39:44 2012 +0200 bug_7647: Table sorter on issue history members/readingrec.tt commit 77b6409802e6ce5612883ec6d22db9545547444a CommitDate: Mon Mar 21 20:02:15 2011 +1300 Bug 5917 : Converted templates Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Removes the id attribute release notes| |from the script tag | |(<script id="js">) for two | |pages in the staff | |interface, as they are not | |needed. | | | |The two pages changed: | |- 'Checkout history' | |section for a record | |- 'Circulation history' for | |a patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41560 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is minor, lets skip backport to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org