[Bug 41359] New: There is no warning when Bcrypt settings are invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 Bug ID: 41359 Summary: There is no warning when Bcrypt settings are invalid Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 1 - Add a line to koha-conf, or replace existing entry: <bcrypt_settings>FALSE</bcrypt_settings> 2 - Enable system preferences for Pseudonymization: Pseudonimization: Enable PseudonymizationPatronFields: All selected PseudonymizationTransactionFields: All selected 3 - Checkout an item to a patron 4 - Check Administration->Jobs->Manage Jobs 5 - Note failed job for Pseudonymization 6 - Check the worker log: /var/log/koha/kohadev/worker-output.log [2025/12/02 16:25:23] [WARN] Uncaught exception processing job id=12: bad base64 encoding at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line 175. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28911 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190086&action=edit Bug 41359: Add a test/warning for Bcrypt settings to the about page This patch adds a simple test of the bcrypt settings to ensure that pseudonymization will work To recreate: 1 - Add a line to koha-conf, or replace existing entry: <bcrypt_settings>FALSE</bcrypt_settings> 2 - Enable system preferences for Pseudonymization: Pseudonimization: Enable PseudonymizationPatronFields: All selected PseudonymizationTransactionFields: All selected 3 - Checkout an item to a patron 4 - Check Administration->Jobs->Manage Jobs 5 - Note failed job for Pseudonymization 6 - Check the worker log: /var/log/koha/kohadev/worker-output.log [2025/12/02 16:25:23] [WARN] Uncaught exception processing job id=12: bad base64 encoding at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line 175. 7 - Check about page - no warning 8 - Apply patch, restart all 9 - Check about page, now there is a warn! 10 - Add a valid entry, you can generate using the code on bug 28911: htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' 11 - Restart all 12 - Confirm the warning is gone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190086|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 190134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190134&action=edit Bug 41359: Add a test/warning for Bcrypt settings to the about page This patch adds a simple test of the bcrypt settings to ensure that pseudonymization will work To recreate: 1 - Add a line to koha-conf, or replace existing entry: <bcrypt_settings>FALSE</bcrypt_settings> 2 - Enable system preferences for Pseudonymization: Pseudonimization: Enable PseudonymizationPatronFields: All selected PseudonymizationTransactionFields: All selected 3 - Checkout an item to a patron 4 - Check Administration->Jobs->Manage Jobs 5 - Note failed job for Pseudonymization 6 - Check the worker log: /var/log/koha/kohadev/worker-output.log [2025/12/02 16:25:23] [WARN] Uncaught exception processing job id=12: bad base64 encoding at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line 175. 7 - Check about page - no warning 8 - Apply patch, restart all 9 - Check about page, now there is a warn! 10 - Add a valid entry, you can generate using the code on bug 28911: htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' 11 - Restart all 12 - Confirm the warning is gone! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This adds a warning to the release notes| |system information section | |in the about Koha pages | |when the Bcrypt settings | |are invalid (More > About | |Koha > System information, | |Bcrypt is a setting used in | |the Koha instance's | |koha-conf.xml file when the | |Pseudonymization system | |preference is enabled). --- Comment #3 from David Nind <david@davidnind.com> --- After the patch, I did notice on the jobs page that even though the job is finished, the progress is shown as 0/1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41238 --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #3)
After the patch, I did notice on the jobs page that even though the job is finished, the progress is shown as 0/1.
Resolved by bug 41238. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- <tr ><th scope="row"><strong>Warning</strong> </th><td>System preference 'Pseudonymization' is set, but bcrypt_settings entry in the configuration is not valid.</td></tr > Is this the new style we really want? I am seeing it more in that template. But thats just a nightmare imo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This seems to be a duplicate development: We already have [% IF config_bcrypt_settings_no_set %] <tr> <th scope="row"><strong>Warning</strong> </th> <td> System preference 'Pseudonymization' is set, but there is not 'bcrypt_settings' entry defined in the $KOHA_CONF file. </td> </tr> [% END %] Since it is not entirely the same, we should merge them here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41359 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org