[Bug 14481] New: Warns when setting permissions for patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Bug ID: 14481 Summary: Warns when setting permissions for patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate warns, go to any patron and click More --> Set permissions (ie follow this link http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/member-flags.pl line 176 member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/member-flags.pl line 176 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 40745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40745&action=edit Bug 14481: Silences warns triggered when setting patron permissions Use of uninitialized value $roadtype To test: 1) Go to any patron page and click More --> Set permissions (or follow this link --> http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) 2) Notice the warns 3) Apply patch and reload page 4) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nick@quecheelibrary.org --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- I get less warns but still one: [Sat Jul 18 21:56:11.743502 2015] [cgi:error] [pid 13693] [client 127.0.0.1:37991] AH01215: [Sat Jul 18 21:56:11 2015] member-flags.pl: Use of uninitialized value in concatenation (.) or string at /home/nick/kohaclone/members/member-flags.pl line 177., referer: http://localhost:8080/cgi-bin/koha/members/moremember.pl?borrowernumber=19 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40745|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45678&action=edit Bug 14481: Warns when setting permissions for patron Use of uninitialized value $roadtype To test: 1) Go to any patron page and click More --> Set permissions (or follow this link --> http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) 2) Notice the warns 3) Apply patch and reload page 4) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45678|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45722&action=edit [SIGNED-OFF] Bug 14481: Warns when setting permissions for patron Use of uninitialized value $roadtype To test: 1) Go to any patron page and click More --> Set permissions (or follow this link --> http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) 2) Notice the warns 3) Apply patch and reload page 4) Notice warns are gone and page still works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> This patch successfully eliminates the 'Use of uninitialized value $roadtype' error in the log. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have not tested, but it cannot work. It will remove the warning, but $roadtype won't be interpret as a variable but as a string :) The consequence is that the address displayed will be "12 $roadtype patron address" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Is it possible we could just remove $roadtype from the details page? I tested having information in every address field and it didn't appear to use $roadtype until I clicked Set permissions. Where does $roadtype actually get used here? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- $roadtype might only appear if you have the authorized value for it set up - it's an older feature that was moved into a system preference a few versions ago. It gives you a pull down for the 'road type' for patron's addresses. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 --- Comment #8 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Which syspref Katrin? I can't seem to see it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah sorry... I meant an authorised value... try adding something like: ROADTYPE - S - Street. When you check your edit patron screen then, it should have changed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 --- Comment #10 from Aleisha Amohia <aleishaamohia@hotmail.com> --- So this warn only shows up when no authorized value has been chosen for roadtype. I've found ways to make the warn disappear, but then it doesn't display the roadtype in the address where it should. Any suggestions for a patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not sure it makes sense to remove this warning, it happens if there is a configuration issue. Moreover, there is something wrong with the display of the roadtype in the address. I am going to open a bug report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This warning will be removed by bug 15542. *** This bug has been marked as a duplicate of bug 15542 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org