http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #1 from Magnus Enger <magnus@enger.priv.no> 2012-01-13 12:10:44 UTC --- Just saw that Makefile.PL still has this: 884 $msg = q( 885 Koha can use the Zebra search engine for high-performance 886 searching of bibliographic and authority records. If you 887 have installed the Zebra software and would like to use it, 888 please answer 'yes' to the following question. Otherwise, 889 Koha will default to using its internal search engine. 890 891 Please note that if you choose *NOT* to install Zebra, 892 koha-conf.xml will still contain some references to Zebra 893 settings. Those references will be ignored by Koha. 894 895 Install the Zebra configuration files?); -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Upgrade from NoZebra installs is broken, as there is code that uses the syspref, which should be completely removed from Koha. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8724 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- To test: - Apply the patch and do a fresh install - Install procedure should "just work as usual" - The nozebra table should not be created - Searching for authorities should remain functional - Add/Modify a biblio/authority record and nothing crashes - Add an item and nothing crashes Keep in mind that most of this patch is the removal of unused contitional if NoZebra blocks, templates showind NoZebra stuff and removal of the sysprefs in te relevant SQL files. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Bug 7440 depends on bug 8724, which changed state. Bug 8724 Summary: Upgrade from NoZebra installs is broken http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8724 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch doesn't apply anymore on master (conflicts on C4/AuthoritiesMarc.pm and C4/Search.pm). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16138|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 16277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16277&action=edit Bug 7440 - Remove NoZebra and QueryRemoveStopWords sysprefs Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- I did a fresh install after applying the patches and can confirm that Koha is still working - web installer OK - nozebra table is not created OK - add/modify/delete biblio/item/authority OK - rebuild_zebra.pl OK - search biblio/authority OK so I will sign off these patches. However, it still remains some references to NoZebra that could be removed: C4/AuthoritiesMarc.pm:331: if (C4::Context->preference('NoZebra')) { C4/AuthoritiesMarc.pm:1416: if (C4::Context->preference('NoZebra')) { C4/AuthoritiesMarc.pm:1417: #nozebra way C4/AuthoritiesMarc.pm:1419: my $rq=$dbh->prepare(qq(SELECT biblionumbers from nozebra where indexname="an" and server="biblioserver" and value="$mergefrom" )); C4/Search.pm:1260: # no stemming/weight/fuzzy in NoZebra C4/Search.pm:1261: if ( C4::Context->preference("NoZebra") ) { koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/stopwords.tt:5:<p style="color: #990000">Important: If NoZebra is set to 'Use' this option will not appear on the admin -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16340&action=edit [SIGNED-OFF] Bug 7440 - Remove NoZebra vestiges Removed NoZebra vestiges. This comprises several code blocks that depend on the NoZebra syspref and NZ related functions/methods. C4::Biblio-> GetNoZebraIndexes _DelBiblioNoZebra _AddBiblioNoZebra C4::Search-> NZgetRecords NZanalyse NZoperatorAND NZoperatorOR NZoperatorNOT NZorder C4::Installer-> set_indexing_engine Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16437&action=edit [PATCH] Bug 7440 - Remove NoZebra vestiges Removed NoZebra vestiges. This comprises several code blocks that depend on the NoZebra syspref and NZ related functions/methods. C4::Biblio-> GetNoZebraIndexes _DelBiblioNoZebra _AddBiblioNoZebra C4::Search-> NZgetRecords NZanalyse NZoperatorAND NZoperatorOR NZoperatorNOT NZorder C4::Installer-> set_indexing_engine Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16439&action=edit Bug 7440 follow-up removing forgotten NoZebra references Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16340|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to comment #18)

QA comments:

investigating, I've found some NoZebra references pending:

There where some bits related to stopwords too, maybe those you find are related. I filled a bug for removing them, for which I haven't provided a bug as spent the time I had rebasing this one. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.