[Bug 8793] New: Remove references to OPAC icons from NORMARC staff XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Priority: P5 - low Change sponsored?: --- Bug ID: 8793 CC: gmcharlt@gmail.com Assignee: magnus@enger.priv.no Summary: Remove references to OPAC icons from NORMARC staff XSLT Severity: minor Classification: Unclassified OS: All Reporter: magnus@enger.priv.no Hardware: All Status: ASSIGNED Version: master Component: Staff Client Product: Koha This was first pointed out on Bug 8624. NORMARCslim2intranetDetail.xsl: <xsl:element name="img"><xsl:attribute name="src">/opac-tmpl/prog/famfamfam/<xsl:value-of select="$materialTypeCode"/>.png</xsl:attribute><xsl:attribute name="alt"></xsl:attribute></xsl:element> NORMARCslim2intranetResults.xsl: <xsl:when test="$typeOf008='Mon'"><img src="/opac-tmpl/prog/famfamfam/silk/book.png" alt="Bok" title="Bok"/> Bok</xsl:when> <xsl:when test="$typeOf008='Per'"><img src="/opac-tmpl/prog/famfamfam/silk/newspaper.png" alt="Periodika" title="Periodika"/> Periodika</xsl:when> <xsl:when test="$typeOf008='Fil'"><img src="/opac-tmpl/prog/famfamfam/silk/computer_link.png" alt="Fil" title="Fil"/> Fil</xsl:when> <xsl:when test="$typeOf008='Kar'"><img src="/opac-tmpl/prog/famfamfam/silk/map.png" alt="Kart" title="Kart"/> Kart</xsl:when> <xsl:when test="$typeOf008='FV'"><img src="/opac-tmpl/prog/famfamfam/silk/film.png" alt="Film og video" title="Film og video"/> Film og video</xsl:when> <xsl:when test="$typeOf008='Mus'"><img src="/opac-tmpl/prog/famfamfam/silk/sound.png" alt="Musikktrykk og lydopptak" title="Musikktrykk og lydopptak"/> Musikk</xsl:when> MARC21 does not seem to use images like this, so I'll probably just remove them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove references to OPAC |Fix |icons from NORMARC staff |materialTypeCode/typeOf008 |XSLT |icons for NORMARC XSLT --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Broadening the scope of this bug a bit, to cover more (closely related) problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 12455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12455&action=edit Bug 8793 - Fix materialTypeCode/typeOf008 icons for NORMARC XSLT This patch fixes some issues with icons related to materialtypes in NORMARC: Remove references to opac-tmpl in the *intranet* NORMARC XSLT files. Add two new icons to koha-tmpl/intranet-tmpl/prog/img/famfamfam/ and koha-tmpl/opac-tmpl/lib/famfamfam/ GR.png - Graphical materials TD.png - Three dimentional objects Copy PR.png from koha-tmpl/intranet-tmpl/prog/img/famfamfam/ to koha-tmpl/opac-tmpl/lib/famfamfam/ Rename the XSLT variable materialTypeCode to typeOf008 for increased consistency between stylesheets. Make sure the XSLT uses icons that are actually available. To test: - No use testing all the different permutations of leader pos. 06 and 019b, I think. - Set marcflavour = NORMARC and turn on default XSLT for OPAC and Intranet, details and results. - Make sure you have a record with something relevant in leader position 6, like g for movies or c for music - Check that the icon turns up in results and details, in the OPAC and Intranet - Toggle DisplayOPACiconsXSLT and check that the results in the OPAC are as expected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |8624 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8662 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12455|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12678&action=edit Bug 8793 - Fix materialTypeCode/typeOf008 icons for NORMARC XSLT This patch fixes some issues with icons related to materialtypes in NORMARC: Remove references to opac-tmpl in the *intranet* NORMARC XSLT files. Add two new icons to koha-tmpl/intranet-tmpl/prog/img/famfamfam/ and koha-tmpl/opac-tmpl/lib/famfamfam/ GR.png - Graphical materials TD.png - Three dimentional objects Copy PR.png from koha-tmpl/intranet-tmpl/prog/img/famfamfam/ to koha-tmpl/opac-tmpl/lib/famfamfam/ Rename the XSLT variable materialTypeCode to typeOf008 for increased consistency between stylesheets. Make sure the XSLT uses icons that are actually available. To test: - No use testing all the different permutations of leader pos. 06 and 019b, I think. - Set marcflavour = NORMARC and turn on default XSLT for OPAC and Intranet, details and results. - Make sure you have a record with something relevant in leader position 6, like g for movies or c for music - Check that the icon turns up in results and details, in the OPAC and Intranet - Toggle DisplayOPACiconsXSLT and check that the results in the OPAC are as expected Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Before patch: OPAC results: +icon, +norwegian descriptions OPAC detail: -icon, +norwegian descriptions; FV.png not found Staff result: -icon, +norwegian descriptions; Film.png, Sound.png not found Staff detail: -icon, +norwegian descriptions; FV.png not found After patch: OPAC results: +icon, +norwegian descriptions OPAC detail: +icon, +norwegian descriptions; (no errors) Staff result: +icon, +norwegian descriptions; (no errors) Staff detail: +icon, +norwegian descriptions; (no errors) I also tried the new icons. GR.png for 'k' (grafiske materialer) and TD.png for tre-dimensjonale gjenstander ('r') works for me in all areas. Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments * add new icons to famfam directory, they are graphically consistent * the rest is related to NORMARC only, no side-effect risk * passes koha-qa.pl passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master (untested, Magnus, please, double check ;-) ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Magnus Enger <magnus@enger.priv.no> --- (In reply to comment #6)
Patch pushed to master (untested, Magnus, please, double check ;-) )
Works nicely on master, as far as I can tell. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Bug 8793 depends on bug 8624, which changed state. Bug 8624 Summary: famfamfam should be outside theme directory http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org