[Bug 8780] New: Lower dependency version for DateTime::TimeZone
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Priority: P5 - low Change sponsored?: --- Bug ID: 8780 Assignee: gmcharlt@gmail.com Summary: Lower dependency version for DateTime::TimeZone Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset@hotmail.com Hardware: All Status: NEW Version: unspecified Component: Installation and upgrade (command-line installer) Product: Koha A base Debian install of 6.0.5 has a DateTime::TimeZone version 1.20 available (including debian.koha-community.org repositories), but the PerlDependencies.pm says 1.26 After discussions on the IRC channel (http://irc.koha-community.org/irclog/koha/2012-09-17) from 08:50-09:35 and 12:44-13:07, I decided to email Colin Campbell. He replied: "No its a nominal number. Looking through the changes log nearly all changes up to current (1.50) are just updates to reflect data changes in some timezones. We're mainly using it for the timezone names so I think 1.20 will be fine. I think the only reason a number was chosen was because one of the install routines didnt allow us just to say any DateTime::TimeZone Cheers Colin" Given that Colin says it should be okay to lower it to 1.20, and that Wajasu has purposefully tweaked his out since June (almost 3 months), I propose we lower the minimum value to 1.20 from 1.26. This will make git installs under Debian attainable. Test ----- 1) Do a fresh git clone on Debian. 2) cd the clone. 3) sudo apt-get install dselect 4) sudo dpkg --set-selections < install_misc/debian.packages 5) sudo dselect 6) choose I, C, R, and then Q. 7) ./koha_perl_deps.pl -m -u 8) Notice that despite being installed, DateTime::TimeZone is 1.20 vs. the required 1.26 now apply patch 9) ./koha_perl_deps.pl -m -u 10) Notice that DateTime::TimeZone is no longer listed. As for the other items, that can be fixed by running my check_deps.sh script which is in the release-tools repo (I believe), and as such, is another bug report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 12299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12299&action=edit DateTime::TimeZone min_ver=1.20 from 1.26 Test plan as above. This patch applies to 3.8.x and master only. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Not fully tested, but with an existing Koha installation (master) I do not longer have a warning regarding DateTime::TimeZone (orange color) on the about page's Perl tab. Not enough to sign off, I'm afraid. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12299|0 |1 is obsolete| | --- Comment #3 from wajasu <matted-34813@mypacks.net> --- Created attachment 12325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12325&action=edit SIGNED-OFF-Bug-8780-Lower-dependency-version-for-DateTime-TimeZone I've been dropping the version back for squeeze for two months now(Jul/Aug/Sept 2012), or all my dev and standard installs. No significant difference that I've seen. Thanks mtompset! One less diversion or hangup for folks. wajasu Note: It would be nice if it gets on 3.8.x and master for 3.10. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matted-34813@mypacks.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> ---
SIGNED-OFF-Bug-8780-Lower-dependency-version-for-DateTime-TimeZone
based on the info from Colin and wajasu, im happy to pass QA on this nice spotting Mark :) $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit bd1f621) * 926840c Bug 8780 - Lower dependency version for DateTime::TimeZone C4/Installer/PerlDependencies.pm * C4/Installer/PerlDependencies.pm OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|unspecified |rel_3_8 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org