https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #1)

Can you explain how sub_location, location and permanent_location would relate to each other?

For example, some of our libraries use it to mark new material. They're located in e.g. adult section so location and permanent_location are marked as "A". But they also have sub_location "NEW" so they are shelved into a specific place. Or items have sub_location "EXHIBIT" so librarians know where to look for them. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #3)

Hm, I think this sounds a bit like the temporary location idea that has been discussed in

Bug 14962 - Temp Shelving Location Bug 31168 - Temporary Item Locations

as New would be temporary. I think some libraries have resolved this by mapping permanent_location to a subfield to make it visible in the items editor. They control them manually then.

Yeah some of the locations are temporary. Some other cases might be that library has a sublocation in their storage for specific items. Or then item has shorter loan time and is shelved separately. So those sublocations are more permanent and might never change, but they are not quite the same as permanent location. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 --- Comment #6 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 157300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157300&action=edit Bug 34142: DO NOT PUSH! Schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I see the new column in the items table but when I save an item with the new field nothing shows up in items.sub_location. I only see the data in more_subfields_xml. Even after manually adding data to items.sub_location, I don't see the information appearing in circ/returns.tt. On the detail page I see the authorized value code instead of the description. Should sub-location appear in every place where location appears? (if so please see Bug 35059) Should sub-location only display when a location is defined? Shouldn't the new column in the table have the same capacity as items.location? The new one is varchar(10) instead of item.location's varchar(80) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157299|0 |1 is obsolete| | --- Comment #9 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 159236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159236&action=edit Bug 34142: Add new column sub_location to (deleted)items Add new column sub_location to items and deleteditems table. Column can be used to indicate e.g. if item has some other more specific location than permanent location. To test: 1) Add new authorized value for sublocation e.g. "SUBLOC" and add some values to it. 2) Add new 952 subfield e.g. S to MARC framework and link your new authorized value "SUBLOC" to it. 3) Link subfield to items.sub_location field in "Koha to MARC mapping" (add 952,S). 4) Find a record and attempt to add new item to it. => Note that new subfield S is now displayed on item form and dropdown selector contains values added to "SUBLOC". => Saving should be successfull. => After saving confirm that sublocation is displayed in its own column in items listing above item form and that sublocation is displayed with correct description. 5) Attempt to modify item. => Confirm that sublocation is displayed and it's correct. 6) Attempt to delete item. => Deleting should be successfull. Also confirm that sub location is displayed on these pages: 1) detail.pl 2) moredetail.pl 3. returns.pl Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #12 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmi Takkinen from comment #11)

Now I'm facing the same problem as Owen. Update runs as it should, but column isn't added to database.

My bad, for some reason column was already in the table but in wrong place. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159236|0 |1 is obsolete| | --- Comment #14 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 164875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164875&action=edit Bug 34142: Add new column sub_location to (deleted)items Add new column sub_location to items and deleteditems table. Column can be used to indicate e.g. if item has some other more specific location than permanent location. To test: 1) Add new authorized value for sublocation e.g. "SUBLOC" and add some values to it. 2) Add new 952 subfield e.g. S to MARC framework and link your new authorized value "SUBLOC" to it. 3) Link subfield to items.sub_location field in "Koha to MARC mapping" (add 952,S). 4) Find a record and attempt to add new item to it. => Note that new subfield S is now displayed on item form and dropdown selector contains values added to "SUBLOC". => Saving should be successfull. => After saving confirm that sublocation is displayed in its own column in items listing above item form and that sublocation is displayed with correct description. 5) Attempt to modify item. => Confirm that sublocation is displayed and it's correct. 6) Attempt to delete item. => Deleting should be successfull. Also confirm that sub location is displayed on these pages: 1) detail.pl 2) moredetail.pl 3. returns.pl Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164876|0 |1 is obsolete| | --- Comment #16 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 164877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164877&action=edit DO NOT PUSH! Schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- This no longer applies cleanly. If you add a column to the holdings/other holdings table I think it needs to accounted for in columns_settings.yml so it can be properly hidden via Table Settings. Setting to FQA for that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164877|0 |1 is obsolete| | --- Comment #19 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 172103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172103&action=edit DO NOT PUSH! Schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 --- Comment #21 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Lucas Gass from comment #18)

This no longer applies cleanly.

If you add a column to the holdings/other holdings table I think it needs to accounted for in columns_settings.yml so it can be properly hidden via Table Settings. Setting to FQA for that.

Rebased patches against current master. Sublocation isn't added to its own column in those tables. It's added in the same column as home library (same as permanent location), so I don't think there is need to include to the columns_settings.yml. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 --- Comment #22 from Philip Orr <philip.orr@lmscloud.de> --- Unfortunately another merge conflict, needs to rebased again. If you can rebase it this week chances are good I can look at it during hackfest :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172104|0 |1 is obsolete| | --- Comment #24 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 179907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179907&action=edit Bug 34142: Add new column sub_location to (deleted)items Add new column sub_location to items and deleteditems table. Column can be used to indicate e.g. if item has some other more specific location than permanent location. To test: 1) Add new authorized value for sublocation e.g. "SUBLOC" and add some values to it. 2) Add new 952 subfield e.g. S to MARC framework and link your new authorized value "SUBLOC" to it. 3) Link subfield to items.sub_location field in "Koha to MARC mapping" (add 952,S). 4) Find a record and attempt to add new item to it. => Note that new subfield S is now displayed on item form and dropdown selector contains values added to "SUBLOC". => Saving should be successfull. => After saving confirm that sublocation is displayed in its own column in items listing above item form and that sublocation is displayed with correct description. 5) Attempt to modify item. => Confirm that sublocation is displayed and it's correct. 6) Attempt to delete item. => Deleting should be successfull. Also confirm that sub location is displayed on these pages: 1) detail.pl 2) moredetail.pl 3) returns.pl Sponsored-by: Koha-Suomi Oy Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from Philip Orr <philip.orr@lmscloud.de> --- Up to step 3 of the test plan everything went fine. I created authorised value SUBLOC, made a couple of values for it. Then in the standard MARC framework, added a new field 952$k "Sublocation" and linked SUBLOC authorised value to it. Made sure to set display on: to items(10) and set the check boxes for display on OPAC, Staff Interface and Editor. Added the definition to items.sub_location in "Koha to MARC mapping" (added 952,k). Then rebuilt. Then saved. All OK. Then I went on to step 4 and as soon as I opened a random title (in this case: "Disjecta" on ktd, biblionumber 22 but I think it happens with any title on ktd) I got the following Error 500: Something went wrong when loading the table. 500: Internal Server Error. Properties not allowed: sub_location. Properties not allowed: sub_location. Properties not allowed: sub_location. Properties not allowed: sub_location. Seems to come from the items table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #28 from Philip Orr <philip.orr@lmscloud.de> --- Thanks Emmi, that did it! Now I can test it :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179906|0 |1 is obsolete| | --- Comment #29 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 180087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180087&action=edit Bug 34142: DO NOT PUSH! Schema changes https://bugs.koha-community.org/show_bug.cgi?id=34142 Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 --- Comment #31 from Philip Orr <philip.orr@lmscloud.de> --- As you said, QA warns it is not tidy. Otherwise tested OK! Would be nice to be able to display the sublocation in the OPAC similar to how it is in the staff interface record display. And for the staff interface, maybe a space between the location and the (sublocation in parentheses) would be good. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 --- Comment #33 from David Cook <dcook@prosentient.com.au> --- (In reply to Emmi Takkinen from comment #4)

Yeah some of the locations are temporary. Some other cases might be that library has a sublocation in their storage for specific items. Or then item has shorter loan time and is shelved separately. So those sublocations are more permanent and might never change, but they are not quite the same as permanent location.

I don't think I understand this explanation. This just sounds like "location" to me? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180087|0 |1 is obsolete| | --- Comment #35 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 185088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185088&action=edit Bug 34142: DO NOT PUSH! Schema changes https://bugs.koha-community.org/show_bug.cgi?id=34142 Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 --- Comment #37 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 185090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185090&action=edit Bug 34142: Add missing whitespace -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I did some testing here: 1) Patches are not passing QA script (Problem) [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt` 2) Schema changes (Note) Something is odd with the attached schema patch as it removes all documentation comments from the schema files and therefore contains many more changes than necessary. As it's not going to be pushed, just noting. 3) Spelling (Suggestion) The code and db use sub_location, but the description for the GUI is sublocation. Should we make them match to make things less confusing down the road? I know we have a lot of these inconsistencies in Koha, but as we are starting out fresh here it might make sense to avoid one more :) description: sub_location for this item + `sub_location` varchar(80) DEFAULT NULL COMMENT 'authorized value for the sublocation for this item', <span class="label">Sublocation:</span> 4) Frameworks und Koha to MARC mappings (OK) This doesn't contain a change to the frameworks or mappings. For existing installations I believe this is OK, as we only have one lower case subfield (k) left and we cannot assume that libraries have not been using any lower or upper case letters in their configurations already. The downside is, that this means the feature won't be active by default in a new installation, so we might want to think about some extra good documentation. I found one oddity while testing: In order for things to work nicely, you have to add the subfield definition to the DEFAULT framework. If you don't, you will have display problems on all pages (sublocation not showing at all or only showing as code). I initially had only added it to the BKS framework and all problems in testing resolved, once it was added to Default as well. This could be something to note in the release notes maybe or in any instructions for setting this up. 5) Authorised value category (Suggestion) It could be a good idea to add an empty authorised value category in the installer files and the database update. It would not 'hurt' and might help to advertise the feature. 6) Testing a) Staff interface - item editor (OK) b) Staff interface - detail page, holdings table (OK) c) Staff interface - detail page, items tab (OK) d) List of checkins (Problem) The sublocation displays, but the location is gone. I believe this could be due to the missing item_ here: - <span class="shelvingloc">[% checkin.item_location | html %]</span> + <span class="shelvingloc">[% checkin.location | html %] [% IF ( checkin.sub_location ) %] ([% checkin.sub_location | html %]) d) Questions * Why is the field not added to the OPAC as well? * Why is it added to the list of returns, but not to the list of checkouts? -- You are receiving this mail because: You are watching all bug changes.