[Bug 36984] New: Transit pending status breaks holdings info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 Bug ID: 36984 Summary: Transit pending status breaks holdings info Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: adolfo.rodriguez@xercode.es QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When you transfer a rotating collection, all the items status change to transit requested. If you check the detail of the bibliography record of any of the items in the collection, it won't show up the items info. It will get stuck Processing because there is a Javascript error. In the console tab, you will see the following message: Uncaught TypeError: Cannot read properties of undefined (reading 'str') -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 --- Comment #1 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Created attachment 167239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167239&action=edit bug 36984 "Transit pending" status breaks the bibliographic record Intranet detail page Test plan: 1 Create a rotating collection 2 Add an item 3 Transfer the collection 4 Check the detail page of the bibliography record of the item in the Intranet. Notice that it's stuck Processing 5 Apply patch, restart services 6 Repeat step 4. Now the item shows up with the text "Transit pending from..." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Thanks for submitting a patch! Unfortunately, the commit message needs to follow the guidelines at https://wiki.koha-community.org/wiki/Commit_messages Example: Bug XXXXX: Whatever the patch does A description of what the problem is that this fixes. Test plan: 1. ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 --- Comment #3 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Created attachment 167269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167269&action=edit bug 36984 Fixes "Transit pending from..." message in bibliographic record detail page Transfering a rotating collection will mark the items contained in the collection as "Transit pending..." and it will trigger a javascript error in the bibliographic record detail page that breaks the holdings table, leaving it caught in the "Processing..." message. This patch fixes that. The javascript messages gives this error in the console tab: Uncaught TypeError: Cannot read properties of undefined (reading 'str') The error comes from using from_library_ insted of from_library in the file koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc Test plan: 1 Create a rotating collection 2 Add at least an item to the collection 3 Transfer the rotating collection 4 Check the detail page of the bibliography record of any of the items that belong to that collection in the Intranet. Notice that the holdings table gets stuck "Processing..." and that there is a Javascript error 5 Apply patch, restart services 6 Repeat step 4. Now the holdings tab works as intended and the item from the collection shows up with the text "Transit pending from..." in the Status column 7 Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 167291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167291&action=edit Bug 36984: Fix "Transit pending from..." message in bibliographic record detail page Transfering a rotating collection will mark the items contained in the collection as "Transit pending..." and it will trigger a javascript error in the bibliographic record detail page that breaks the holdings table, leaving it caught in the "Processing..." message. This patch fixes that. The javascript messages gives this error in the console tab: Uncaught TypeError: Cannot read properties of undefined (reading 'str') The error comes from using from_library_ insted of from_library in the file koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc Test plan: 1 Create a rotating collection 2 Add at least an item to the collection 3 Transfer the rotating collection 4 Check the detail page of the bibliography record of any of the items that belong to that collection in the Intranet. Notice that the holdings table gets stuck "Processing..." and that there is a Javascript error 5 Apply patch, restart services 6 Repeat step 4. Now the holdings tab works as intended and the item from the collection shows up with the text "Transit pending from..." in the Status column 7 Sign off Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the holdings release notes| |table for a record in the | |staff interface so that | |when transferring rotation | |collections, the "Transit | |pending..." messages | |display correctly instead | |of displaying "Processing" | |and not displaying the | |items available. --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Adolfo! I've amended the bug title to: Bug 36984: Fix .... Testing notes using koha-testing-docker (KTD): 1. To set up a rotating collection: 1.1 Enable the StockRotation system preference 1.2 Go to Tools > Patrons and circulation > Rotating collections 1.3 Add a new collection: + New collection 1.4 Add items to a collection: add barcodes, for example 39999000011418 and 39999000005134 Tip: To make it simpler, add items that are located in Centerville. 1.5 Transfer the collection: . From the collection page, select 'Transfer'. . Choose another library. . Select 'Transfer collection'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167269|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167291|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167759&action=edit Bug 36984: Fix "Transit pending from..." message in bibliographic record detail page Transfering a rotating collection will mark the items contained in the collection as "Transit pending..." and it will trigger a javascript error in the bibliographic record detail page that breaks the holdings table, leaving it caught in the "Processing..." message. This patch fixes that. The javascript messages gives this error in the console tab: Uncaught TypeError: Cannot read properties of undefined (reading 'str') The error comes from using from_library_ insted of from_library in the file koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc Test plan: 1 Create a rotating collection 2 Add at least an item to the collection 3 Transfer the rotating collection 4 Check the detail page of the bibliography record of any of the items that belong to that collection in the Intranet. Notice that the holdings table gets stuck "Processing..." and that there is a Javascript error 5 Apply patch, restart services 6 Repeat step 4. Now the holdings tab works as intended and the item from the collection shows up with the text "Transit pending from..." in the Status column 7 Sign off Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA Assignee|koha-bugs@lists.koha-commun |adolfo.rodriguez@xercode.es |ity.org | Patch complexity|--- |Trivial patch --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks for catching that, Adolfo! Passing QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33568 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33568 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the holdings |This fixes the status shown release notes|table for a record in the |in the holdings table for a |staff interface so that |record in the staff |when transferring rotation |interface when transferring |collections, the "Transit |rotation collections. It |pending..." messages |now correctly shows as |display correctly instead |"Transit pending...", |of displaying "Processing" |instead of showing as |and not displaying the |"Processing" and not |items available. |displaying the items | |available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the status shown |This fixes the status shown release notes|in the holdings table for a |in the staff interface |record in the staff |holdings table for a record |interface when transferring |when transferring rotation |rotation collections. It |collections. It now |now correctly shows as |correctly shows as "Transit |"Transit pending...", |pending...", instead of |instead of showing as |showing as "Processing" and |"Processing" and not |not displaying the items |displaying the items |available. |available. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36984 Bug 36984 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org