https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Searching |Templates Version|unspecified |Main Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37773 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183279&action=edit Bug 37773: Show search term in cataloging search results This patch updates the cataloging search results page so that the search term is shown in the page title, breadcrumb, and headings. To test, apply the patch and go to Cataloging in the staff interface. - Perform searches which will return varying results: - A search which returns records in both the catalog and the reservoir (perform some Z39.50 searches if the reservoir is empty). - A search which returns records in the catalog but not the reservoir. - A search which returns records in the reservoir but not the catalog. - A search which returns no results at all. - In all cases, check the page title, breadcrumbs, and headings. Your search term should appear as expected. - Test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the template e.g. misc/translator/po/fr-FR-messages.po - Locate strings pulled from addbooks.tt for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt:93 #: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt:207 #, fuzzy, perl-brace-format msgid "No catalog search results for '{query}'" msgstr "Résultats de recherche pour '{query}'" - Delete the line starting with "#, fuzzy" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR - Switch to your updated translation in the staff interface and perform the same tests as above. The translations should appear as expected. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37773 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Automatic patch test results: â ï¸ The patch applies with fuzzy option (ignoring whitespace). This may indicate minor conflicts that need to be resolved. Details: Patch applies with fuzzy option (ignoring whitespace) This is an automated message from the patch testing system. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183279|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 190559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190559&action=edit Bug 37773: Show search term in cataloging search results This patch updates the cataloging search results page so that the search term is shown in the page title, breadcrumb, and headings. To test, apply the patch and go to Cataloging in the staff interface. - Perform searches which will return varying results: - A search which returns records in both the catalog and the reservoir (perform some Z39.50 searches if the reservoir is empty). - A search which returns records in the catalog but not the reservoir. - A search which returns records in the reservoir but not the catalog. - A search which returns no results at all. - In all cases, check the page title, breadcrumbs, and headings. Your search term should appear as expected. - Test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the template e.g. misc/translator/po/fr-FR-messages.po - Locate strings pulled from addbooks.tt for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt:93 #: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt:207 #, fuzzy, perl-brace-format msgid "No catalog search results for '{query}'" msgstr "Résultats de recherche pour '{query}'" - Delete the line starting with "#, fuzzy" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR - Switch to your updated translation in the staff interface and perform the same tests as above. The translations should appear as expected. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37773 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.