[Bug 33544] New: Squash some ILL fields to alleviate request table overflow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Bug ID: 33544 Summary: Squash some ILL fields to alleviate request table overflow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com The ILL requests' table listing all ILL requests is prone to overflowing it's container and requiring horizontal scrolling. This is against a number of accessibility guidelines, and just doesn't look very nice. I believe we could merge a number of the current columns to display the same data vertically in one column. I think the item details (author, title, article title, issue, volume, year, pages) could all be merged into a column that looks more like how we display search catalogue search results. That would save us a lot of horizontal space to start with. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd like to see a POC for this one and also think this might be what's best here to resolve the space issue. But we need to make sure that the information is still clearly distinguishable for librarians working with ILLs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] ILL API response objects inconsistent with other endpoints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We'll knock something up once we have bug 22440 pushed :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Bug 33544 depends on bug 22440, which changed state. Bug 22440 Summary: Improve ILL page performance by moving to server side filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152860&action=edit Bug 33544: WIP Replace title details with one column Work in progress to combine the request title details fields into one column for display. table_settings needs to be changed to account for the new and missing fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152860|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152861&action=edit Bug 33544: WIP Replace title details with one column Work in progress to combine the request title details fields into one column for display. table_settings needs to be changed to account for the new and missing fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152862&action=edit Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152863&action=edit New 'details' column Screenshot of new column. Horizontal scrollbar still there but much less prominent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Current WIP is breaking the small search input box on top of the table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com --- Comment #8 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- Bug 22384 suggests making the title clickable, which could be the "details' column and reduce one more column in width. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22384 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. The biblio column is now a clickable representation of the biblio already.. it uses $biblio_to_html behind the scenes. The other details that this patch merges into one field are those that were entered by the user when making the request.. We don't always have a linked biblio. Needs a little thought -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159528&action=edit Bug 33544: Replace title details with one column Combine the request title details fields into onea column for display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152862|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159529&action=edit Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159530&action=edit Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- The table doesn't load and there's this error in the console: SyntaxError: Unexpected token ':' (at ill-list-table_23.1200006.js:231:23) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159528|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162945&action=edit Bug 33544: Replace title details with one column Combine the request title details fields into onea column for display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159529|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162946&action=edit Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159530|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162947&action=edit Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just a quick rebase here now that master has moved again.. I couldn't replicate your bug I'm afraid though Lisette. I'll try to swing back around and dig a little deeper when I get a moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #18 from David Nind <david@davidnind.com> --- I had a go at testing, however I think with some of the changes in train for ILL that this may need some more work? I tested with the ILL FreeForm backend, with the 24.05.x branch. However, after the patch the list of ILL requests does not actually list the requests - you get the table headings, but no details and a JavScript error (when using the developer tools): Uncaught SyntaxError: Unexpected token ':' (at ill-list-table_24.0600000.js:246:23) No metadata enrichment plugins found. ill-batch-modal_24.0600000.js:4 Draft test plan: 1. Enable the ILL module and an ILL backend: . bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) . change to the FreeForm directory: cd Koha/Illbackends/FreeForm . checkout the 24.05.x branch: git checkout 24.05.x 2. Create an ILL request (any type is fine, Journal article recommended) 3. List all ILL requests - note that table goes off the page to the right). 4. Apply the patch and restart everything. 5. Duplicate the tab (so that you can compare the table layout) and refresh the page. 6. Notice that: . the title details (columns for author, title, article title, issue, volume, year, pages) are now in one column, Request details . there is a Batch column (?) . to edit the request, click on XXX . the table no longer overflows 7. Sign off D: -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #19 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 33544 Bug 33544 - Squash some ILL fields to alleviate request table overflow 162945 - Bug 33544: Replace title details with one column 162946 - Bug 33544: Update columns_settings.yml 162947 - Bug 33544: Link title in details to biblio Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33544: Replace title details with one column Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js error: Failed to merge in the changes. Patch failed at 0001 Bug 33544: Replace title details with one column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #20 from Mathieu Saby <mathsabypro@gmail.com> --- This table is not nice at all, especially with an action button in the last column, which is displayed off-screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #21 from Mathieu Saby <mathsabypro@gmail.com> --- I would like to test this patch. Could you rebase it please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #22 from Mathieu Saby <mathsabypro@gmail.com> ---
From your capture, even with your patch the action button on the last column will be out of screen :/
Is there places in Koha where action button within tables are on the 1st column rather than the last one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #23 from Mathieu Saby <mathsabypro@gmail.com> --- I am not sure the biblionumber should have its own colum. Why not using it to make a link to the title record in the 1st column ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- I tried running the auto-rebase script on this (after applying it to 285a0fc74da5747922bcc28626066a7067e4fb66) but it did not like it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #25 from Eric Phetteplace <ephetteplace@cca.edu> --- It seems to be Koha convention to put the action button in the right-most column (e.g. for Reports) but the opposite, putting it on the left, is more usable. I frequently have trouble with horizontal-scrolling (which is more difficult than vertical scrolling in most web browsers) when tables contain many columns. Just an opinion, I do not know if this is a formalized convention that would violate a style guide or merely how things tend to have been done. Which is all to say I very much appreciate this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #26 from Mathieu Saby <mathsabypro@gmail.com> --- I don't care if it is on the right or the left but on UX point of view it is not good to have to scroll to access the button. There are at least 1 place in Koha where action buttons are on the left : the edit item table (koha/cataloguing/additem.pl?op=edititem). But maybe not a good idea to follow this example. Anyway moving the button is not the goal of this patch... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162945|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179227&action=edit Bug 33544: Replace title details with one column Combine the request title details fields into onea column for display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162946|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179228&action=edit Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162947|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179229&action=edit Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Applies again now.. only twenty-three months gone by. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179229|0 |1 is obsolete| | --- Comment #31 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 179232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179232&action=edit Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179228|0 |1 is obsolete| | --- Comment #32 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 179233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179233&action=edit Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179227|0 |1 is obsolete| | --- Comment #33 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 179234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179234&action=edit Bug 33544: Replace title details with one column Combine the request title details fields into one column for display. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #34 from Lisette Scheer <lisette@bywatersolutions.com> --- While I agree that having buttons on the left makes sense for usability, that's a larger convention change than the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #35 from Eric Phetteplace <ephetteplace@cca.edu> --- These patches apply if you apply them in reverse order; I applied Update columns_settings.yml, then Replace title details with one column, and then Link title in details to biblio and it worked and passed the testing plan. The Batch column is present but hidden by default (which seems sensible to me). The table does, however, overflow still. Is it possible to reorder attachments on Bugzilla? Or would deleting the first patch and adding it as a "new" patch work? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179234|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187202&action=edit Bug 33544: Replace title details with one column Combine the request title details fields into onea column for display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179233|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187203&action=edit Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179232|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187204&action=edit Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187205&action=edit Bug 33544: Combine title details into single column This patch consolidates the separate title details fields (title, author, year, etc.) into a single combined column in the ILL requests table for improved display and reduced horizontal scrolling. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187206&action=edit Bug 33544: Update columns_settings.yml for consolidated details column This patch removes the now-unused individual column definitions from columns_settings.yml, replacing them with a single 'details' column configuration. Note: Fields combined into a single column are no longer individually sortable. I believe this is acceptable for the ILL requests fields selected for display consolidation to reduce horizontal overflow. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187207&action=edit Bug 33544: Move biblio ID into title link This patch removes the separate biblio_id column and instead embeds the biblio link directly within the title field of the details column, reducing table width while maintaining access to the full record. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187203|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187204|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Another rebase and a reword of the commit messages to clarify intent.. actual code content hasn't changed however, so I kept the signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187205|0 |1 is obsolete| | --- Comment #43 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 191974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191974&action=edit Bug 33544: Combine title details into single column This patch consolidates the separate title details fields (title, author, year, etc.) into a single combined column in the ILL requests table for improved display and reduced horizontal scrolling. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187206|0 |1 is obsolete| | --- Comment #44 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 191975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191975&action=edit Bug 33544: Update columns_settings.yml for consolidated details column This patch removes the now-unused individual column definitions from columns_settings.yml, replacing them with a single 'details' column configuration. Note: Fields combined into a single column are no longer individually sortable. I believe this is acceptable for the ILL requests fields selected for display consolidation to reduce horizontal overflow. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187207|0 |1 is obsolete| | --- Comment #45 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 191976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191976&action=edit Bug 33544: Move biblio ID into title link This patch removes the separate biblio_id column and instead embeds the biblio link directly within the title field of the details column, reducing table width while maintaining access to the full record. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #46 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 191977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191977&action=edit Bug 33544: (QA follow-up) fixed misspelled attribute Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |Laura.escamilla@bywatersolu | |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #47 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- After fixing a super tiny spelling error this worked great! Thanks, Martin for keeping this one moving! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #49 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org