[Bug 25101] New: Add ability to skip previewing results when batch extending due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Bug ID: 25101 Summary: Add ability to skip previewing results when batch extending due dates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102650&action=edit Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25020 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020 [Bug 25020] Extending due dates to a specified date should preserve time portion of original due date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102650|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 102654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102654&action=edit Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 25088 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Kyle, Regarding the comments and numbers from bug 25088, I do not understand how this patch could fix the problem. Did you identify the bottleneck? I mean, if the preview screen timeout I am expecting the confirmation screen to timeout as well. And I feel like it's better to timeout in the preview screen if there are too many matching rows (at least there is not only an unknown part of the set that is modified). If it's really the first screen that is a problem, that means there are superfluoux datetime manipulations (see my patch on bug 25008 to give you an idea) or something else that is causing the timeout. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also I think we should have the checkbox checked by default, and a note/tooltip explaining a bit what's doing exactly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
Also I think we should have the checkbox checked by default, and a note/tooltip explaining a bit what's doing exactly.
With this patch, it can at least run. I'll file a followup for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about adding a command line script instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7)
What about adding a command line script instead?
The purpose of the tool is to allow librarians to update the due dates themselves. A cli tool would obviate the point of the tool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #9 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 106937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106937&action=edit Bug 25101: (follow-up) Tick preview checkbox on by default This would prevent any unintended batch renewals as it is easy to miss the option in the screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #10 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Kyle, I added patch for enabling the checkbox by default. Please let us know how you want to proceed with this, now this in bit of a limbo state. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Joonas Kylmälä from comment #10)
Kyle, I added patch for enabling the checkbox by default. Please let us know how you want to proceed with this, now this in bit of a limbo state.
That is fine by me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #12 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Kyle M Hall from comment #11)
That is fine by me!
Just to be clear, ready for someone to QA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102654|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109292&action=edit Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106937|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109293&action=edit Bug 25101: (follow-up) Tick preview checkbox on by default This would prevent any unintended batch renewals as it is easy to miss the option in the screen. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109294&action=edit Bug 25101: (QA follow-up) Add hint to new option Adds a hint about the large numbers behind the new checkbox option. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If I understand correctly jumping the preview helps in that the renewals will be done. Even if the screen times out, they will finish in the background, but with the preview step in between, you never get there. I have tried to add the hint Joubu asked for - please feel free to rephrase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- No, the hint is not correct IMO. The preview will fail if there is a large amounts of due dates to extend. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Oh, you are right - good intentions, but wrong "direction". Kyle, could you provide a rephrase maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- * The preview will fail if there is a large amounts of due dates to extend. * This is recommended when changing very large numbers of due dates. I don't see the difference here. Jonathan, would you like me to use your direct phrasing as the hint? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not a native English speaker but for me the 2 sentences have opposite sense. The hint from Katrin's patch is "This is recommended when changing very large numbers of due dates." Which means: you should check it if you are processing a lot of issues. It's the reverse, if the checkbox is checked we are going to display the preview screen, which will fail if the amount of due dates is too large. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- A new day, maybe the fix is simple: "This is not recommended when changing very large numbers of due dates." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #20)
I am not a native English speaker but for me the 2 sentences have opposite sense.
The hint from Katrin's patch is "This is recommended when changing very large numbers of due dates."
Which means: you should check it if you are processing a lot of issues.
It's the reverse, if the checkbox is checked we are going to display the preview screen, which will fail if the amount of due dates is too large.
Ah! That wasn't clicking for me, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #21)
A new day, maybe the fix is simple:
"This is not recommended when changing very large numbers of due dates."
Perfect! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109425&action=edit Bug 25101: (QA follow-up) Fix hint for new option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109292|0 |1 is obsolete| | Attachment #109293|0 |1 is obsolete| | Attachment #109294|0 |1 is obsolete| | Attachment #109425|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109529&action=edit Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 25101: (QA follow-up) Add hint to new option Adds a hint about the large numbers behind the new checkbox option. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 25101: (QA follow-up) Fix hint for new option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109530&action=edit Bug 25101: (follow-up) Tick preview checkbox on by default This would prevent any unintended batch renewals as it is easy to miss the option in the screen. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #28 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org