[Bug 24520] New: Share via Twitter option on OPAC is out of line with rest of Share options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24520 Bug ID: 24520 Summary: Share via Twitter option on OPAC is out of line with rest of Share options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: lucas@bywatersolutions.com Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would appear as most Share options, email, facebook, linkedin are Font Awesome - however, the Tweet option is not. Therefore when the Tweet Options appears next to the other share options, it is out of line with them. It would be nice to make the Tweet option also Font Awesome to keep them consistent and look nice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24520 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- The tweet link is a Font Awesome icon, but there is also some JavaScript which loads Twitter's version of the button in its place. I must have it blocked in my browser because I didn't see it until I switched to another one. The solution is to remove the Twitter-specific JS: Line 1410: [% IF ( SocialNetworks ) %] <script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script> [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24520 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- This problem is fixed by Bug 26069. Making this resolved *** This bug has been marked as a duplicate of bug 26069 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org