https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 101874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101874&action=edit Bug 24991: make koha-sip --restart start sip if it is not already running. To test: - make sure SIP is enabled sudo koha-sip --enable inst - make sure SIP is running sudo koha-sip --start inst sudo koha-sip --status inst - restart SIP, make sure it does this normally sudo koha-sip --restart inst - stop SIP, make sure it does this normally sudo koha-sip --stop inst - make sure SIP is not running (wild scenario: oomkiller or similar has killed this or some other thing has happened) sudo koha-sip --status inst - restart sip, make sure it starts SIP instead of silently failing sudo koha-sip --restart inst - check SIP is now running, or that there is an error message if it can't start sudo koha-sip --status inst -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- I think this needs to be updated after bug 24993 got pushed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24993 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch looks trivial, but it's not. 1. There is blank line if restart called and sip is stopped. I will fix. 2. There is no consistency on --restart behaviour for debian scripts. Some stop && start, others don't start if was stopped. Not considering blocker but noting it. 3. Wondering if we won't hit the same problem as bug 24993, but for the start command: 170 if [ "$verbose" != "no" ]; then 171 log_daemon_msg "Warning: SIP server not running for ${name}... trying to start" 172 log_end_msg 0 173 fi 174 if is_sip_running ${name}; then 175 return 0 176 else We may not return 0 here if the startup was slow. Do you have this patch applied on production servers? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129807|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130059&action=edit Bug 24991: make koha-sip --restart start sip if it is not already running. To test: - make sure SIP is enabled sudo koha-sip --enable inst - make sure SIP is running sudo koha-sip --start inst sudo koha-sip --status inst - restart SIP, make sure it does this normally sudo koha-sip --restart inst - stop SIP, make sure it does this normally sudo koha-sip --stop inst - make sure SIP is not running (wild scenario: oomkiller or similar has killed this or some other thing has happened) sudo koha-sip --status inst - restart sip, make sure it starts SIP instead of silently failing sudo koha-sip --restart inst - check SIP is now running, or that there is an error message if it can't start sudo koha-sip --status inst Signed-off-by: Owen Leonard <oleonard@myacpl.org> JD Amended patch: tidy the whole block -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I think that it is inconsistent to check if SIP started in the else block while we are not doing the same for the IF block. We could move a part of the else block AFTER the end if in order to always check if SIP started. Or just not check like we did? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.