https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24993 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch looks trivial, but it's not. 1. There is blank line if restart called and sip is stopped. I will fix. 2. There is no consistency on --restart behaviour for debian scripts. Some stop && start, others don't start if was stopped. Not considering blocker but noting it. 3. Wondering if we won't hit the same problem as bug 24993, but for the start command: 170 if [ "$verbose" != "no" ]; then 171 log_daemon_msg "Warning: SIP server not running for ${name}... trying to start" 172 log_end_msg 0 173 fi 174 if is_sip_running ${name}; then 175 return 0 176 else We may not return 0 here if the startup was slow. Do you have this patch applied on production servers? -- You are receiving this mail because: You are watching all bug changes.