[Bug 32260] New: Prevent alert when searching patron (autocomplete)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 Bug ID: 32260 Summary: Prevent alert when searching patron (autocomplete) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144048&action=edit Bug 32260: Patron autocomplete - Do not display an alert if request is rejected Not sure what is going on exactly, neither if this patch is the correct way to fix this. The request is "rejected" at some point (by the browser?), when we search for patrons using the autocomplete and DT "at the same time". To recreate: Don't apply this patch Go to /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=5 Search for "edn" then hit enter You may see an alert, that will disappear If you don't see the alert, repeat This patch suggests to ignore the alert if the status of the request is "rejected". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32261 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144048|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 144057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144057&action=edit Bug 32260: Patron autocomplete - Do not display an alert if request is rejected Not sure what is going on exactly, neither if this patch is the correct way to fix this. The request is "rejected" at some point (by the browser?), when we search for patrons using the autocomplete and DT "at the same time". To recreate: Don't apply this patch Go to /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=5 Search for "edn" then hit enter You may see an alert, that will disappear If you don't see the alert, repeat This patch suggests to ignore the alert if the status of the request is "rejected". Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I was able to reproduce this problem by following the test plan, bug specifically: - You must search for a string which will return only one result. - You must enter the string and hit ENTER before the autocomplete has time to show any results. I was able to do this by copying the string and using Ctrl-V to quickly paste and hit enter right away. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144057|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144092&action=edit Bug 32260: Patron autocomplete - Do not display an alert if request is rejected Not sure what is going on exactly, neither if this patch is the correct way to fix this. The request is "rejected" at some point (by the browser?), when we search for patrons using the autocomplete and DT "at the same time". To recreate: Don't apply this patch Go to /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=5 Search for "edn" then hit enter You may see an alert, that will disappear If you don't see the alert, repeat This patch suggests to ignore the alert if the status of the request is "rejected". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org