https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|Staff interface |Templates Depends on|30952 |32016 Version|unspecified |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016 [Bug 32016] Fix 'clear filter' button behavior on datatable saving their state -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 144159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144159&action=edit Bug 32303: DT pagination on system preference search result This patch updates the way we retrieve a DataTable's saved state during initialization. The change is to prevent cases where making a duplicate call to DataTables() initializes the table again. To recreate the bug, search system preferences for the term "last." Scroll down to the "OPAC preferences" section and observe that there are two filter forms displayed above it. Apply the patch and perform the same search again. The extra forms should be gone. Confirm that DataTables behavior is still the same: - Test pages which use the "saveState" option in DataTables. - Type text in the table's search field - Reload the page. The search field should still have the string you entered, and the "Clear filter" button should be active. - Administration -> Libraries - Acquisitions -> Vendor -> Receive shipments -> Receive orders - Circulation -> Overdues - Test pages which don't use the "saveState" option, e.g. the checkout screen, patron search results, list of saved reports, etc. The behavior of the search form and table operations in general should be unchanged. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144159|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 144178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144178&action=edit Bug 32303: DT pagination on system preference search result This patch updates the way we retrieve a DataTable's saved state during initialization. The change is to prevent cases where making a duplicate call to DataTables() initializes the table again. To recreate the bug, search system preferences for the term "last." Scroll down to the "OPAC preferences" section and observe that there are two filter forms displayed above it. Apply the patch and perform the same search again. The extra forms should be gone. Confirm that DataTables behavior is still the same: - Test pages which use the "saveState" option in DataTables. - Type text in the table's search field - Reload the page. The search field should still have the string you entered, and the "Clear filter" button should be active. - Administration -> Libraries - Acquisitions -> Vendor -> Receive shipments -> Receive orders - Circulation -> Overdues - Test pages which don't use the "saveState" option, e.g. the checkout screen, patron search results, list of saved reports, etc. The behavior of the search form and table operations in general should be unchanged. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144178|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144187&action=edit Bug 32303: Remove DT pagination on system preference search result This patch updates the way we retrieve a DataTable's saved state during initialization. The change is to prevent cases where making a duplicate call to DataTables() initializes the table again. To recreate the bug, search system preferences for the term "last." Scroll down to the "OPAC preferences" section and observe that there are two filter forms displayed above it. Apply the patch and perform the same search again. The extra forms should be gone. Confirm that DataTables behavior is still the same: - Test pages which use the "saveState" option in DataTables. - Type text in the table's search field - Reload the page. The search field should still have the string you entered, and the "Clear filter" button should be active. - Administration -> Libraries - Acquisitions -> Vendor -> Receive shipments -> Receive orders - Circulation -> Overdues - Test pages which don't use the "saveState" option, e.g. the checkout screen, patron search results, list of saved reports, etc. The behavior of the search form and table operations in general should be unchanged. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.