[Bug 22664] New: Link basket name and basket group name instead of just the number in order search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Bug ID: 22664 Summary: Link basket name and basket group name instead of just the number in order search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Currently the link is only on the number, that can be hard to see and hard to click. I propose to link the name as well. Example: Basket name (1) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87546&action=edit Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer@bsz-bw.de |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87546|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87547&action=edit Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87547|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87549&action=edit Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Summary|Link basket name and basket |Link basket name and basket |group name instead of just |group name instead of the, |the number in order search |often short, basket numbers |results |in order search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87549|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88159&action=edit Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice improvement, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I do however wonder.. are there other places we should make such a change too to be consistent for UX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I plan on doing some more, if noone beats me to it. Already noticed the issue is also on the receive page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- let's do a bunch for 10 years. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88246&action=edit Bug 22664: More making acquisitions links more easily clickable To test: * create a basket with an order from a staged record, and an order from a suggestion * add that basket to a basket group when you close it. * note that the links to the basket in the first column, the link to the basket group in the second column, and the link to the suggester in the summary column are very small (only the ID# is linked) * apply this patch, restart the things * refresh the page, note that the previously ogled links are now bigger and easier to find and click, and that the links work and such * rejoice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88246|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 88290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88290&action=edit Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 --- Comment #12 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 88291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88291&action=edit Bug 22664: More making acquisitions links more easily clickable To test: * create a basket with an order from a staged record, and an order from a suggestion * add that basket to a basket group when you close it. * note that the links to the basket in the first column, the link to the basket group in the second column, and the link to the suggester in the summary column are very small (only the ID# is linked) * apply this patch, restart the things * refresh the page, note that the previously ogled links are now bigger and easier to find and click, and that the links work and such * rejoice. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #13 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Liz Rea from comment #9)
Created attachment 88246 [details] [review] Bug 22664: More making acquisitions links more easily clickable
To test:
* create a basket with an order from a staged record, and an order from a suggestion * add that basket to a basket group when you close it. * note that the links to the basket in the first column, the link to the basket group in the second column, and the link to the suggester in the summary column are very small (only the ID# is linked) * apply this patch, restart the things * refresh the page, note that the previously ogled links are now bigger and easier to find and click, and that the links work and such * rejoice.
Looked ok, thanks Liz ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88290|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88684&action=edit Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88291|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88685&action=edit Bug 22664: More making acquisitions links more easily clickable To test: * create a basket with an order from a staged record, and an order from a suggestion * add that basket to a basket group when you close it. * note that the links to the basket in the first column, the link to the basket group in the second column, and the link to the suggester in the summary column are very small (only the ID# is linked) * apply this patch, restart the things * refresh the page, note that the previously ogled links are now bigger and easier to find and click, and that the links work and such * rejoice. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Link basket name and basket |Link basket name and basket |group name instead of the, |group name instead of the, |often short, basket numbers |often short, basket numbers |in order search results | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement moves the release notes| |basket link from the basket | |number to the basket name | |aiding usability and | |improving consistency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org