[Bug 23431] New: having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Bug ID: 23431 Summary: having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org Similar to bug 23151, if DOB is a field removed by PatronSelfModificationBorrowerUnwantedField, the date of birth gets nullified when the changes are submitted. To replicate: Turn on OPACPatronDetails put dateofbirth in PatronSelfModificationBorrowerUnwantedField Have a patron with a set date of birth Attempt any modification on that patron through the OPAC The date of birth will be one of the fields changed for that borrower when you check it in the OPAC. A work around is to remove dateofbirth from PatronSelfModificationBorrowerUnwantedField and hide the field from that form, if that is desired, with jquery; something like $("#opac-patron-update #memberentry_identity > ol:nth-child(2) > li:nth-child(3)").hide(); Note that it is .hide() and not .remove(). .remove() will cause the same behaviour as DOB being in PatronSelfModificationBorrowerUnwantedField. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23151 CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- +1 Confirmed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 92021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92021&action=edit Bug 23431 - Don't nullify DOB if it's hidden by sysprefs To test: Turn on OPACPatronDetails put dateofbirth in PatronSelfModificationBorrowerUnwantedField Have a patron with a set date of birth Attempt any modification on that patron through the OPAC The date of birth will be one of the fields changed for that borrower when you check it in the staff intranet. Apply this patch, repeat the above. Date of birth will not be one of the changed fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92021|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 92027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92027&action=edit Bug 23431: Don't nullify DOB if it's hidden by sysprefs To test: Turn on OPACPatronDetails put dateofbirth in PatronSelfModificationBorrowerUnwantedField Have a patron with a set date of birth Attempt any modification on that patron through the OPAC The date of birth will be one of the fields changed for that borrower when you check it in the staff intranet. Apply this patch, repeat the above. Date of birth will not be one of the changed fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92027|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92033&action=edit Bug 23431: Don't nullify DOB if it's hidden by sysprefs To test: Turn on OPACPatronDetails put dateofbirth in PatronSelfModificationBorrowerUnwantedField Have a patron with a set date of birth Attempt any modification on that patron through the OPAC The date of birth will be one of the fields changed for that borrower when you check it in the staff intranet. Apply this patch, repeat the above. Date of birth will not be one of the changed fields. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92033|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92068&action=edit Bug 23431: Don't nullify DOB if it's hidden by sysprefs To test: Turn on OPACPatronDetails put dateofbirth in PatronSelfModificationBorrowerUnwantedField Have a patron with a set date of birth Attempt any modification on that patron through the OPAC The date of birth will be one of the fields changed for that borrower when you check it in the staff intranet. Apply this patch, repeat the above. Date of birth will not be one of the changed fields. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial patch that works as expected.. It would have been nice to have an accompanying selenium regression test, but I don't feel it warrants a QA failure for it (especially as it's a major). Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Margaret <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00,19.05.03 |19.11.00,19.05.03,18.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org