[Bug 19573] New: Link to make a new list in masthead in OPAC only appears / works if no other list already exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Bug ID: 19573 Summary: Link to make a new list in masthead in OPAC only appears / works if no other list already exists Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The new enhancement from bug 17948 allows for a quick New List option in the List function found in the masthead in OPAC. This enhancement can only be seen when the patron has no lists already created. If a patron has a private list created, the option for that New List will not appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69067&action=edit Bug 19573: Link to make a new list in masthead in OPAC only appears / works if no other list already exists This patch corrects the OPAC masthead include file so that the "New list" link will appear whether or not the logged-in user has existing private lists. To test, apply the patch and log into the OPAC as both a user with private lists and a user without private lists. The header's "Lists" dropdown menu should include a "New list" link in both cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69067|0 |1 is obsolete| | --- Comment #2 from Simon Pouchol <simon.pouchol@biblibre.com> --- Created attachment 69081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69081&action=edit Bug 19573: Link to make a new list in masthead in OPAC only appears / works if no other list already exists This patch corrects the OPAC masthead include file so that the "New list" link will appear whether or not the logged-in user has existing private lists. To test, apply the patch and log into the OPAC as both a user with private lists and a user without private lists. The header's "Lists" dropdown menu should include a "New list" link in both cases. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.pouchol@biblibre.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |simon.pouchol@biblibre.com CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Simon, please make sure to assign the bug to yourself when you provide a patch, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|simon.pouchol@biblibre.com |oleonard@myacpl.org --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah... misread, changing back and sorry. No more bugs before breakfast :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69081|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 69987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69987&action=edit Bug 19573: Link to make a new list in masthead in OPAC only appears / works if no other list already exists This patch corrects the OPAC masthead include file so that the "New list" link will appear whether or not the logged-in user has existing private lists. To test, apply the patch and log into the OPAC as both a user with private lists and a user without private lists. The header's "Lists" dropdown menu should include a "New list" link in both cases. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org