[Bug 19756] New: Strange upgrade message from updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Bug ID: 19756 Summary: Strange upgrade message from updatedatabase.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Created attachment 69552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69552&action=edit Strange message while upgrading to 17.12.00.000 Upgrading to current master (17.12.00.0000) displays a strange message (seems to be encoding problem). See screenshot from Firefox ESR 45.3.0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- That will be some problem encoding the macrons in the update text. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13793 Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (I am not sure about that I guess this has been added by bug 13793) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 [Bug 13793] The installer does not output the result of the update using Plack -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69980&action=edit Bug 19756: Fix encoding issues during the update DB process To display the output of the updatedatabase.pl under Plack, we redirect the output to a temporary file, read it, then display it. We need to open it specifying the correct encoding (utf-8). Test plan: 1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000" where variable="version"; 2. restart plack 3. Login 4. Make the update from the interface => Without this patch you will see encoding issue: Upgrade to 17.12.00.000 done (TÄ tÅia, tÄ haumatia) => With this patch applied you will see : Upgrade to 17.12.00.000 done (Tē tōia, tē haumatia) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Strange upgrade message |Encoding issues when update |from updatedatabase.pl |DB is run from the | |interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69980|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 69983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69983&action=edit Bug 19756: Fix encoding issues during the update DB process To display the output of the updatedatabase.pl under Plack, we redirect the output to a temporary file, read it, then display it. We need to open it specifying the correct encoding (utf-8). Test plan: 1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000" where variable="version"; 2. restart plack 3. Login 4. Make the update from the interface => Without this patch you will see encoding issue: Upgrade to 17.12.00.000 done (TÄ tÅia, tÄ haumatia) => With this patch applied you will see : Upgrade to 17.12.00.000 done (Tē tōia, tē haumatia) Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69983|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 70040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70040&action=edit Bug 19756: Fix encoding issues during the update DB process To display the output of the updatedatabase.pl under Plack, we redirect the output to a temporary file, read it, then display it. We need to open it specifying the correct encoding (utf-8). Test plan: 1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000" where variable="version"; 2. restart plack 3. Login 4. Make the update from the interface => Without this patch you will see encoding issue: Upgrade to 17.12.00.000 done (TÄ tÅia, tÄ haumatia) => With this patch applied you will see : Upgrade to 17.12.00.000 done (Tē tōia, tē haumatia) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org