[Bug 38359] New: ILL pages offset no longer works after bootstrap 5 upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Bug ID: 38359 Summary: ILL pages offset no longer works after bootstrap 5 upgrade Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: pedro.amorim@ptfs-europe.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: david@davidnind.com, oleonard@myacpl.org, pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Depends on: 35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173983&action=edit Bug 38359: Update css class col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead Test plan: 1) Enable ILLModule sys pref 2) Attempt to create a new ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Notice there is no left offset (as was before bug 35402 4) Apply patch. Repeat. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173983|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173984&action=edit Bug 38359: Update css class col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead Test plan: 1) Enable ILLModule sys pref 2) Attempt to create a new ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Notice there is no left offset (as was before bug 35402 4) After creating the request, see the detail page: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 5) Verify same issue happens here. 6) Apply patch. Repeat test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILL pages offset no longer |ILL UI pages offset no |works after bootstrap 5 |longer works after |upgrade |bootstrap 5 upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Please note that: $ git grep "col-sm-offset-2" # returns many other occurrences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Ewa Gózd <ewa.gozd@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ewa.gozd@gmail.com Summary|ILL UI pages offset no |ILL UI pages offset no |longer works after |longer works after |bootstrap 5 upgrade |Bootstrap 5 upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173984|0 |1 is obsolete| | --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174053&action=edit Bug 38359: Update css class col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead Test plan: 1) Enable ILLModule sys pref 2) Attempt to create a new ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Notice there is no left offset (as was before bug 35402 4) After creating the request, see the detail page: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 5) Verify same issue happens here. 6) Apply patch. Repeat test plan. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- That looks much better, thanks Pedro. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174053|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 174100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174100&action=edit Bug 38359: Update css class col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead Test plan: 1) Enable ILLModule sys pref 2) Attempt to create a new ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Notice there is no left offset (as was before bug 35402 4) After creating the request, see the detail page: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 5) Verify same issue happens here. 6) Apply patch. Repeat test plan. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 --- Comment #7 from David Nind <david@davidnind.com> --- Adding my sign-off, so that maybe Lucas's sign-off could count as QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #7)
Adding my sign-off, so that maybe Lucas's sign-off could count as QA.
Yes, I am happy to count mine as Passed QA here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Bug 38359 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38359 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org