[Bug 38394] New: Remove try/catch and say_failures for 24.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Bug ID: 38394 Summary: Remove try/catch and say_failures for 24.11 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com On bug 37895 we have failed to propose a solution to encapsulate exceptions and rethrow them. Until this is ready we should not try/catch and so use say_failure from our DB revs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37895 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174239&action=edit Bug 38394: Remove existing try/catch and say_failure from DB revs On bug 37895 we have failed to propose a solution to encapsulate exceptions and rethrow them. Until this is ready we should not try/catch and so use say_failure from our DB revs. We want to stop the DB update process when something is wrong. In those try/catch we are actually continuing even if something bad happens. As RaiseError is set on the dbh, say_failure statements will never be reached. Test plan: checkout origin/24.05.0 reset_all checkout main + this patch updatedatabase Everything should run fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174240&action=edit Bug 38394: Remove 3 'done' We don't want that, and it's not consistent with the other outputs. If we don't have anything useful to say, don't say anything. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37895 [Bug 37895] Update skeleton.pl to show an example use of coding guideline SQL14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've removed say_failure from https://wiki.koha-community.org/wiki/Database_updates as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Reviewed carefully, going to push these. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- btw, found some inconsistencies in the DB output * "Added OAI-PMH:HarvestEmailReport system preference" should be "Added new system preference 'OAI-PMH:HarvestEmailReport'" * Added new system preference 'JobsNotificationMethod' is white instead of green * Added column 'service_platformerm_usage_data_providers' is blue (why not green?) * "list_borrowers added to 1 users with manage_bookings" should be better worded, like "Added permissions 'permission' to ..." * "Added BOOKING_CANCELLATION authorised value category" should be "Added new authorised value category 'CAT'" * "Updated manage_search_targets permission description" => this is only noise -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #5)
btw, found some inconsistencies in the DB output
* "Added OAI-PMH:HarvestEmailReport system preference" should be "Added new system preference 'OAI-PMH:HarvestEmailReport'"
* Added new system preference 'JobsNotificationMethod' is white instead of green
* Added column 'service_platformerm_usage_data_providers' is blue (why not green?)
* "list_borrowers added to 1 users with manage_bookings" should be better worded, like "Added permissions 'permission' to ..."
* "Added BOOKING_CANCELLATION authorised value category" should be "Added new authorised value category 'CAT'"
* "Updated manage_search_targets permission description" => this is only noise
I agree that these slipped through and I also corrected many before pushing already. Follow-up's woudl be very welcome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38448 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 [Bug 38448] Fix inconsistencies in database update messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Moved to Bug 38448 - Fix inconsistencies in database update messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org