[Bug 33133] New: Fast cataloging should be visible in cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Bug ID: 33133 Summary: Fast cataloging should be visible in cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If a user has only 'fast cataloging' permission they should still see the Cataloging link on the home page, and be able to see a link for fast cataloging. Currently, if you have only fast cataloging (and staffaccess) you can brose to cataloging.pl, but you get a blank page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147739&action=edit Bug 33133: Add fast cataloging to 'Cataloging' page This patch adds a check for the existence of the Fast Add framework to the Koha mainpage and the cataloging home page If it exists, and the user has fast cataloging permission then there will be a link to Cataloging on the home page, and to Fast add on the cataloging page To test: 1 - Have two patrons, one with superlibrarian and one with only catalogue + fast_cataloging 2 - Make sure you have a fast add framework (code:FA) 3 - Have two windows/tabs one with each patron (one private/incognito or use two browsers) 4 - View mainpage.pl for both 5 - Superlibrarian has Catalogue link, other does not 6 - Browse to http://localhost:8081/cgi-bin/koha/cataloguing/cataloging-home.pl 7 - Superlibrarian sees stuff, other can access page, but has no buttons 8 - Apply patch 9 - Repeat 4 - both have a link 10 - Repeat 7 - both have a link to fast add 11 - Confirm fast add link works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147739|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 147837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147837&action=edit Bug 33133: Add fast cataloging to 'Cataloging' page This patch adds a check for the existence of the Fast Add framework to the Koha mainpage and the cataloging home page If it exists, and the user has fast cataloging permission then there will be a link to Cataloging on the home page, and to Fast add on the cataloging page To test: 1 - Have two patrons, one with superlibrarian and one with only catalogue + fast_cataloging 2 - Make sure you have a fast add framework (code:FA) 3 - Have two windows/tabs one with each patron (one private/incognito or use two browsers) 4 - View mainpage.pl for both 5 - Superlibrarian has Catalogue link, other does not 6 - Browse to http://localhost:8081/cgi-bin/koha/cataloguing/cataloging-home.pl 7 - Superlibrarian sees stuff, other can access page, but has no buttons 8 - Apply patch 9 - Repeat 4 - both have a link 10 - Repeat 7 - both have a link to fast add 11 - Confirm fast add link works Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described, thanks for the patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 2 things: 1) Why check for the existance of the FA framework on the staff interface start page, but not on the cataloguing start page? 2) I don't feel like Fast cataloguing is a tool and it gets really lost in the 3rd column. Maybe we could move it into the first column on top or even into the toolbar of the cataloging page? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148165&action=edit Bug 33133: Move fast cataloging to first column This move the link and adds its own heading -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
2 things:
1) Why check for the existance of the FA framework on the staff interface start page, but not on the cataloguing start page?
I do test: in script: $template->param( fast_cataloging => 1 ) if $frameworks->find({ frameworkcode => 'FA' }); in template: ( fast_cataloging && CAN_user_editcatalogue_fast_cataloging )
2) I don't feel like Fast cataloguing is a tool and it gets really lost in the 3rd column. Maybe we could move it into the first column on top or even into the toolbar of the cataloging page?
Moved to first column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147837|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148241&action=edit Bug 33133: Add fast cataloging to 'Cataloging' page This patch adds a check for the existence of the Fast Add framework to the Koha mainpage and the cataloging home page If it exists, and the user has fast cataloging permission then there will be a link to Cataloging on the home page, and to Fast add on the cataloging page To test: 1 - Have two patrons, one with superlibrarian and one with only catalogue + fast_cataloging 2 - Make sure you have a fast add framework (code:FA) 3 - Have two windows/tabs one with each patron (one private/incognito or use two browsers) 4 - View mainpage.pl for both 5 - Superlibrarian has Catalogue link, other does not 6 - Browse to http://localhost:8081/cgi-bin/koha/cataloguing/cataloging-home.pl 7 - Superlibrarian sees stuff, other can access page, but has no buttons 8 - Apply patch 9 - Repeat 4 - both have a link 10 - Repeat 7 - both have a link to fast add 11 - Confirm fast add link works Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148165|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148242&action=edit Bug 33133: Move fast cataloging to first column This move the link and adds its own heading Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice fix, thanks Nick Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ooops, I stole your QA Katrin.. apologies.. it's all looking good to me here now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #10)
Ooops, I stole your QA Katrin.. apologies.. it's all looking good to me here now :)
I was going to ask for another opinion anyway :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org