[Bug 32883] New: Curbside pickups - Order "To be staged" by date and time of scheduled pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Bug ID: 32883 Summary: Curbside pickups - Order "To be staged" by date and time of scheduled pickup Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The entries in the "To be staged" tab in the curbside pickup module should be ordered by date and time of the scheduled pickup so that we can address the most pressing/the soonest first. Right now, I'm not sure how they are ordered... Maybe in the order they were scheduled? To test: 1. Enable the CurbsidePickup system preference 2. Set up curbside pickup for a library (e.g. Centerville) 2.1. Go to Administration > Curbside pickup 2.2. Click the tab for the library 2.3. Fill out the form: - Enable: Check - Pickup interval: 10 (or other) - Maximum patrons per interval: 3 (or other) - Patron-scheduled pickup: leave unchecked - Enable for waiting holds only: leave unchecked 2.4. Enter a couple of time periods (e.g. - Day: Sunday - From: 10:00 - To: 12:00 2.5. Click 'Add' 2.6. Click 'Save configuration' 3. Schedule a pickup 3.1. Go to Circulation > Curbside pickups 3.2. Click 'Schedule pickup' 3.3. Search for a patron name (e.g. Henry) 3.4. Pick a date 3.5. Pick a time (not the first one, e.g. 10:50) 3.6. Click 'Submit' 4. Schedule a second pickup, in a time slot before the other one 4.1. Search for a patron name (e.g. Edna) 4.2. Pick the same date 4.3. Pick a time before the time selected in step 3.5 (e.g. 10:10) 4.4. Submit 5. Check the "To be staged" tab --> Pickups are not ordered from soonest to latest pickup time I think the table should maybe be a datatable with column configuration, search boxes and the arrows to order a column, to match all other tables in Koha, with the default order on the 'Pickup date/time' column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Add a curbside pickup module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Bug 32883 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146283&action=edit Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by staged (mark as staged) date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- We could add DataTables to those tables, but this one line patch is fixing the default sort. It should be done on a separate bug in my opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The patch works as advertised. I'm not sure about the "Staged and ready" order... Shouldn't it still be by scheduled pickup time? I've never used this IRL, so I'm not sure of the workflow, but I feel like I could prepare the pickups in any order (as I come to them on my holds shelf for example, or I picked them up on my holds shelf, put them on a cart and went to my desk to scan them), but I'd still want to see the most "pressing" at the top, so I can check if the patron is there... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32890 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I created bug 32890 for the datatables thing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146283|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146305&action=edit Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by pickup date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Caroline Cyr La Rose from comment #3)
I'm not sure about the "Staged and ready" order... Shouldn't it still be by scheduled pickup time?
Yes, I think you are right. I modified the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146305|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 146334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146334&action=edit Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by pickup date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Cool, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- The "Patron is outside" tab is now order by "arrival" but we still only display "Pickup date/time" I think we want to order by the pickup date/time - so even if the patron arrives early, they still get their pickup in their slot We should show the arrival time, but that's not for this bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |koha-bugs@lists.koha-commun |com |ity.org --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Then I think the line should be: { order_by => [ { -desc => 'delivered_datetime' }, 'scheduled_pickup_datetime' ], } I won't have time to work more on this soon unfortunately. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146334|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148163&action=edit Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by pickup date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148164&action=edit Bug 32883: (QA follow-up) Adjust ordering for pickups Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org