[Bug 26782] New: Circulation conditions: first 2 columns show as sortable, but cannot be sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Bug ID: 26782 Summary: Circulation conditions: first 2 columns show as sortable, but cannot be sorted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The first 2 columns for patron category and item type have the little arrow marker, but won't sort when clicked on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21946 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- The table is configured to not be sortable, and the default sort is indicated by the arrows. I agree that it is deceptive especially when the cursor indicates a link. We'll have to see if there's a way to attach a style somehow to the fixed and sorted columns to correct it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 [Bug 21946] Group circulation by item type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112220&action=edit Bug 26782: Add new class for indicating default sort without sortability This patch adds to the globally-included CSS a class which can be added to tables when they are configured using DataTables options that set a default sort but don't allow the user to reorder columns. The new class shows a grey rather than blue sorting indicator and sets the cursort to the default pointer rather than the link "hand." To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Go to Administration -> Circulation and fine rules In the table of circulation rules, confirm that the first two columns, "Patron category" and "Item type" have a grey sorting icon in the header cell indicating ascencing sort. Hovering the cursor over these cells should show a default arrow cursor rather than the link cursor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112220|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 112466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112466&action=edit Bug 26782: Add new class for indicating default sort without sortability This patch adds to the globally-included CSS a class which can be added to tables when they are configured using DataTables options that set a default sort but don't allow the user to reorder columns. The new class shows a grey rather than blue sorting indicator and sets the cursort to the default pointer rather than the link "hand." To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Go to Administration -> Circulation and fine rules In the table of circulation rules, confirm that the first two columns, "Patron category" and "Item type" have a grey sorting icon in the header cell indicating ascencing sort. Hovering the cursor over these cells should show a default arrow cursor rather than the link cursor. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112466|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112476&action=edit Bug 26782: Add new class for indicating default sort without sortability This patch adds to the globally-included CSS a class which can be added to tables when they are configured using DataTables options that set a default sort but don't allow the user to reorder columns. The new class shows a grey rather than blue sorting indicator and sets the cursort to the default pointer rather than the link "hand." To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Go to Administration -> Circulation and fine rules In the table of circulation rules, confirm that the first two columns, "Patron category" and "Item type" have a grey sorting icon in the header cell indicating ascencing sort. Hovering the cursor over these cells should show a default arrow cursor rather than the link cursor. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Bug 26782 depends on bug 21946, which changed state. Bug 21946 Summary: Group circulation by item type https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org