[Bug 26669] New: Last Run column not updated when report is run publicly (via CoverFlow or elsewhere)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Bug ID: 26669 Summary: Last Run column not updated when report is run publicly (via CoverFlow or elsewhere) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org Reports show an inaccurate last run date for reports used by CoverFlow. Shouldn't it show that activity, or would coverflow report timestamps bog the system down? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- I think I know why. Last run is only updated with execute_query() is called with report ID. This id is sometimes missing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27432 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 [Bug 14024] Add reports to action logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 115165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115165&action=edit Bug 26669: Avoid a warn in update_sql In C4/Reports/Guided.pm update_sql() called by test suite return warn : Use of uninitialized value $sql in substitution (s///) Test plan : Run prove t/db_dependent/Reports/Guided.t and see warning disapearing (whouchhhh) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 115166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115166&action=edit Bug 26669: Last Run if report not always updated The last run of a report is updated only if method execute_query() is called with report_id. This whas missing for : - when report is run publicly - when report is sent by email - when report is exported Patch changes the method signature to use a hash of params, in order to easily avoid some params. Test plan is coming... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Here is a fix. But it needs a big test plan. Christopher, do you think you can create the test plan for where patch has an impact ? I'm actually short on time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Fridolin Somers from comment #4)
Here is a fix. But it needs a big test plan.
Christopher, do you think you can create the test plan for where patch has an impact ? I'm actually short on time.
Not sure how well I can. I was only able to observe that it wasn't updating for our coverflow reports. I can't even test the ability to send report in e-mail, as I don't have that functionality on a test server. And I am not sure which method of e-mailing you are referring to. Are you talking about using the scheduling feature, or e-mailing from the backend like we do through ByWater via a cron job (I think)? If I had to guess, I would say: 1) Create a report. 2) Run report. 3) Check the report listing. Confirm that the last run info on the report is updated. 4) Make report public. 5) Run report via public url. 6) Check the report listing. Confirm that the last run info on the report IS NOT updated. 7) Schedule the report to run at a given time and e-mailed to an address. 8) After the report runs at the scheduled time, check the report listing. Confirm that the last run info on the report IS NOT updated. 9) Run report. 10) Export results. 11) Check the report listing. Confirm that the last run info on the report IS NOT updated AT THE TIME OF THE EXPORT. Questionable (I don't know if this is addressed): 12) Run report on backend through a cron job and send results via e-mail. 13) Check the report listing. Confirm that the last run info on the report IS NOT updated. 14) Apply patch. 15) Rerun steps 2-13. Confirm that steps 3, 6, 8, 11, and 13 DO UPDATE the last run info. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks good to me, thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115166|0 |1 is obsolete| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 115414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115414&action=edit Bug 26669: Last Run if report not always updated The last run of a report is updated only if method execute_query() is called with report_id. This whas missing for : - when report is run publicly - when report is sent by email - when report is exported Patch changes the method signature to use a hash of params, in order to easily avoid some params. Test plan : 1) Create a report. 2) Run report. 3) Check the report listing. Confirm that the last run info on the report is updated. 4) Make report public. 5) Run report via public url. 6) Check the report listing. Confirm that the last run info on the report IS NOT updated. 7) Schedule the report to run at a given time and e-mailed to an address. 8) After the report runs at the scheduled time, check the report listing. Confirm that the last run info on the report IS NOT updated. 9) Run report. 10) Export results. 11) Check the report listing. Confirm that the last run info on the report IS NOT updated AT THE TIME OF THE EXPORT. Questionable (I don't know if this is addressed): 12) Run report on backend through a cron job and send results via e-mail. 13) Check the report listing. Confirm that the last run info on the report IS NOT updated. 14) Apply patch. 15) Rerun steps 2-13. Confirm that steps 3, 6, 8, 11, and 13 DO UPDATE the last run info. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27511 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115414|0 |1 is obsolete| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 131539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131539&action=edit Bug 26669: Last Run if report not always updated The last run of a report is updated only if method execute_query() is called with report_id. This whas missing for : - when report is run publicly - when report is sent by email - when report is exported Patch changes the method signature to use a hash of params, in order to easily avoid some params. Test plan : 1) Create a report. 2) Run report. 3) Check the report listing. Confirm that the last run info on the report is updated. 4) Make report public. 5) Run report via public url. 6) Check the report listing. Confirm that the last run info on the report IS NOT updated. 7) Schedule the report to run at a given time and e-mailed to an address. 8) After the report runs at the scheduled time, check the report listing. Confirm that the last run info on the report IS NOT updated. 9) Run report. 10) Export results. 11) Check the report listing. Confirm that the last run info on the report IS NOT updated AT THE TIME OF THE EXPORT. Questionable (I don't know if this is addressed): 12) Run report on backend through a cron job and send results via e-mail. 13) Check the report listing. Confirm that the last run info on the report IS NOT updated. 14) Apply patch. 15) Rerun steps 2-13. Confirm that steps 3, 6, 8, 11, and 13 DO UPDATE the last run info. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131539|0 |1 is obsolete| | --- Comment #9 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132547&action=edit Bug 26669: Last Run if report not always updated The last run of a report is updated only if method execute_query() is called with report_id. This whas missing for : - when report is run publicly - when report is sent by email - when report is exported Patch changes the method signature to use a hash of params, in order to easily avoid some params. Test plan : 1) Create a report. 2) Run report. 3) Check the report listing. Confirm that the last run info on the report is updated. 4) Make report public. 5) Run report via public url. 6) Check the report listing. Confirm that the last run info on the report IS NOT updated. 7) Schedule the report to run at a given time and e-mailed to an address. 8) After the report runs at the scheduled time, check the report listing. Confirm that the last run info on the report IS NOT updated. 9) Run report. 10) Export results. 11) Check the report listing. Confirm that the last run info on the report IS NOT updated AT THE TIME OF THE EXPORT. Questionable (I don't know if this is addressed): 12) Run report on backend through a cron job and send results via e-mail. 13) Check the report listing. Confirm that the last run info on the report IS NOT updated. 14) Apply patch. 15) Rerun steps 2-13. Confirm that steps 3, 6, 8, 11, and 13 DO UPDATE the last run info. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115165|0 |1 is obsolete| | --- Comment #10 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132548&action=edit Bug 26669: Avoid a warn in update_sql In C4/Reports/Guided.pm update_sql() called by test suite return warn : Use of uninitialized value $sql in substitution (s///) Test plan : Run prove t/db_dependent/Reports/Guided.t and see warning disapearing (whouchhhh) Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132547|0 |1 is obsolete| | --- Comment #11 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132549&action=edit Bug 26669: Last Run if report not always updated The last run of a report is updated only if method execute_query() is called with report_id. This whas missing for : - when report is run publicly - when report is sent by email - when report is exported Patch changes the method signature to use a hash of params, in order to easily avoid some params. Test plan : 1) Create a report. 2) Run report. 3) Check the report listing. Confirm that the last run info on the report is updated. 4) Make report public. 5) Run report via public url. 6) Check the report listing. Confirm that the last run info on the report IS NOT updated. 7) Schedule the report to run at a given time and e-mailed to an address. 8) After the report runs at the scheduled time, check the report listing. Confirm that the last run info on the report IS NOT updated. 9) Run report. 10) Export results. 11) Check the report listing. Confirm that the last run info on the report IS NOT updated AT THE TIME OF THE EXPORT. Questionable (I don't know if this is addressed): 12) Run report on backend through a cron job and send results via e-mail. 13) Check the report listing. Confirm that the last run info on the report IS NOT updated. 14) Apply patch. 15) Rerun steps 2-13. Confirm that steps 3, 6, 8, 11, and 13 DO UPDATE the last run info. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #12 from Séverine Queune <severine.queune@bulac.fr> --- Seemed ok for me : timestamp in Last run column was updated after all the 3 mentionned actions. Thanks Frido ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132548|0 |1 is obsolete| | Attachment #132549|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132587&action=edit Bug 26669: Avoid a warn in update_sql In C4/Reports/Guided.pm update_sql() called by test suite return warn : Use of uninitialized value $sql in substitution (s///) Test plan : Run prove t/db_dependent/Reports/Guided.t and see warning disapearing (whouchhhh) Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132588&action=edit Bug 26669: Last Run if report not always updated The last run of a report is updated only if method execute_query() is called with report_id. This whas missing for : - when report is run publicly - when report is sent by email - when report is exported Patch changes the method signature to use a hash of params, in order to easily avoid some params. Test plan : 1) Create a report. 2) Run report. 3) Check the report listing. Confirm that the last run info on the report is updated. 4) Make report public. 5) Run report via public url. 6) Check the report listing. Confirm that the last run info on the report IS NOT updated. 7) Schedule the report to run at a given time and e-mailed to an address. 8) After the report runs at the scheduled time, check the report listing. Confirm that the last run info on the report IS NOT updated. 9) Run report. 10) Export results. 11) Check the report listing. Confirm that the last run info on the report IS NOT updated AT THE TIME OF THE EXPORT. Questionable (I don't know if this is addressed): 12) Run report on backend through a cron job and send results via e-mail. 13) Check the report listing. Confirm that the last run info on the report IS NOT updated. 14) Apply patch. 15) Rerun steps 2-13. Confirm that steps 3, 6, 8, 11, and 13 DO UPDATE the last run info. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132589&action=edit Bug 26669: Adjust POD Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132590&action=edit Bug 26669: (QA follow-up) Update last run when report run by name This alters the svc scripts to set the report id after fetchign the report object to ensure it is passed to exectue query Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- The only ones that I saw failing before were: Running report by name: http://kohadev.mydnsname.org:8080/cgi-bin/koha/svc/report?name=Test patron_emailer: perl misc/cronjobs/patron_emailer.pl --report 19 --commit --notice BREAD --module catalogue --verbose All works after and is nice to pass params I added a fix for name, fixed up the POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.05 released in| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> --- I note now that the coverflow plugin is broken {"error":"Unhandled exception (Can't use string (\"SELECT DISTINCT biblio.title, bi\"...) as a HASH ref while \"strict refs\" in use at \/usr\/share\/koha\/lib\/C4\/Reports\/Guided.pm line 559.\n)"} Is there a plan to release a fixed coverflow plugin soon? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Chris Cormack from comment #20)
I note now that the coverflow plugin is broken
{"error":"Unhandled exception (Can't use string (\"SELECT DISTINCT biblio.title, bi\"...) as a HASH ref while \"strict refs\" in use at \/usr\/share\/koha\/lib\/C4\/Reports\/Guided.pm line 559.\n)"}
Is there a plan to release a fixed coverflow plugin soon?
New release this morning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669 --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> --- Thanks Nick -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org