https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100375&action=edit Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero. Test Plan: 1) Make 3 return claims for a patron 2) Set ClaimReturnedWarningThreshold to 4 3) Note the claims warning displays for the patron on circulation.pl 4) Apply this patch 5) Reload circulation.pl, the warning should go away 6) Set ClaimReturnedWarningThreshold to 2 7) Reload the page, the warning should reappear -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101582|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101779&action=edit Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero. Test Plan: 1) Make 3 return claims for a patron 2) Set ClaimReturnedWarningThreshold to 4 3) Note the claims warning displays for the patron on circulation.pl 4) Apply this patch 5) Reload circulation.pl, the warning should go away 6) Set ClaimReturnedWarningThreshold to 2 7) Reload the page, the warning should reappear Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.