[Bug 24475] New: Reword FinesMode system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Bug ID: 24475 Summary: Reword FinesMode system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The text for FinesMode reads: (Don't Calculate / Calculate and Charge / Calculate but only for mailing to the admin) fines (when misc/cronjobs/fines.pl is being run). NOTE: Fines can also be charged by the CalculateFinesOnReturn system preference. NOTE: This system preference requires the misc/cronjobs/fines.pl cronjob. Ask your system administrator to schedule it. This gives the impression that CalculateFinesOnReturn is an alternative to FinesMode -- that one could set FinesMode to "Don't calculate" and turn on CalculateFinesOnReturn in order to only calculate fines when an item is checked in. However, CalculateFinesOnReturn only works when FinesMode is set to "Calculate and charge." CalculateFinesOnReturn is an alternative to the fines cron, not to FinesMode. I'll think on better wording here and get back to this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com, | |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Proposed wording: (Don't Calculate / Calculate and Charge / Calculate but only for mailing to the admin) fines (when misc/cronjobs/fines.pl is being run and/or CalculateFinesOnReturn is enabled). NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Also, while we're at it, CalculateFinesOnReturn needs a note of: NOTE: This system preference requires FinesMode to be set to "Calculate and charge." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21633 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21633 CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, the third option doesn't work and is in process to be removed - maybe we should make this one dependent: bug 21633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 [Bug 21633] Did finesMode = test ever send email? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I was just talking to Nick about that. I'll feel him out about an expected timeline there. This isn't strictly dependent on his change and I'd like to see this changed sooner rather than later. Have had a few libraries inadvertently make themselves fine-free by misunderstanding this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #5 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 97954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97954&action=edit Bug 24475: Reword FinesMode system preference This patch changes the wording of the FinesMode and CalculateFinesOnReturn syste m preferences explanations 1) Install Patch 2) Check that the wording of the FinesMode system preference has changed to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned." 3) Check that the wording of the CalculateFinesOnReturn system preference has changed to add "NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'" to the existing note. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from David Roberts <david.roberts@ptfs-europe.com> --- Working on the assumption that this is a purely cosmetic change and the actual functional changes to the system preference discussed here will be resolved elsewhere, I've changed the wording on these two system preferences. I don't think that the change I've made here will depend on the changes in bug 21633. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Failing QA because the text added to CalculateFinesOnReturn has an extra period. It says : NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'. Should be: NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.' Sorry, very trivial. Thanks for writing this! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97954|0 |1 is obsolete| | --- Comment #8 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 97984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97984&action=edit Bug 24475: Reword FinesMode system preference This patch changes the wording of the FinesMode and CalculateFinesOnReturn system preferences explanations 1) Install Patch 2) Check that the wording of the FinesMode system preference has changed to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned." 3) Check that the wording of the CalculateFinesOnReturn system preference has changed to add "NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'" to the existing note. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from David Roberts <david.roberts@ptfs-europe.com> --- Typo removed, and new patch submitted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #11 from David Roberts <david.roberts@ptfs-europe.com> --- That's odd - it seems to apply OK on the PTFS Europe sandboxes, and on my dev server. Please can you try again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 99003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99003&action=edit error message This is the error Kyle got when trying to apply this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #13 from David Roberts <david.roberts@ptfs-europe.com> --- Very odd. I'll rewrite and re-submit. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Tried it again on the sandbox, was unsuccessful again. Kyle tried it on his system, was also unsuccessful, and pulled out an error, which I've attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97984|0 |1 is obsolete| | --- Comment #15 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 101780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101780&action=edit Bug 24475: Reword FinesMode system preference This patch changes the wording of the FinesMode and CalculateFinesOnReturn system preferences explanations 1) Install Patch 2) Check that the wording of the FinesMode system preference has changed to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned." 3) Check that the wording of the CalculateFinesOnReturn system preference has changed to add "NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'" to the existing note. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from David Roberts <david.roberts@ptfs-europe.com> --- Third time lucky (hopefully!). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101780|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 101800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101800&action=edit Bug 24475: Reword FinesMode system preference This patch changes the wording of the FinesMode and CalculateFinesOnReturn system preferences explanations 1) Install Patch 2) Check that the wording of the FinesMode system preference has changed to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned." 3) Check that the wording of the CalculateFinesOnReturn system preference has changed to add "NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'" to the existing note. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101800|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101811&action=edit Bug 24475: Reword FinesMode system preference This patch changes the wording of the FinesMode and CalculateFinesOnReturn system preferences explanations 1) Install Patch 2) Check that the wording of the FinesMode system preference has changed to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned." 3) Check that the wording of the CalculateFinesOnReturn system preference has changed to add "NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'" to the existing note. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101812&action=edit Bug 24475: Cronjobs don't always live in misc In git installs, cronjobs live in misc, but for package installs, they live under bin. Let's just still with 'misc/cronjobs' which is always cromulent. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #21 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org