[Bug 41340] New: Better translatability on 'batch_item_record_modification.inc'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Bug ID: 41340 Summary: Better translatability on 'batch_item_record_modification.inc' Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 23010 introduced a couple 'item(s)' occurrences which we've been trying to avoid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |23010 Assignee|oleonard@myacpl.org |tomascohen@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 [Bug 23010] If an item is checked out or in transit it should not be able to be marked withdrawn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190053&action=edit Bug 41340: Better translatability on 'batch_item_record_modification.inc' Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- + [% tnx('{count} item modified', '{count} items modified', modified_items_count, { count = modified_items_count }) | html %] + [% tnx('(with {count} field modified).', '(with {count} fields modified).', modified_fields_count, { count = modified_fields_count }) | html %] It's not really helping to split the sentence here. However I don't see how we can have something perfect here. Maybe we remove the 'with' and have the number of fields in parenthesis, so we can still split. The idea would be: txn({count} item(s) modified) + '(' + txn({count} field(s) modified) + ')' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #2)
The idea would be: txn({count} item(s) modified) + '(' + txn({count} field(s) modified) + ')'
How about this: ``` <span> [% tnx( '{count} item modified (with {modified_fields} field modified).', '{count} items modified (with {modified_fields} field modified).', modified_items_count, { count = modified_items_count modified_fields = modified_fields_count }) | html %] </span> ``` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190064&action=edit Bug 41340: Better translatability on 'batch_item_record_modification.inc' Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190053|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190064|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 190142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190142&action=edit Bug 41340: Better translatability on 'batch_item_record_modification.inc' Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- I've signed off based on the comments and reviewing the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Bug 41340 depends on bug 23010, which changed state. Bug 23010 Summary: If an item is checked out or in transit it should not be able to be marked withdrawn https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190142|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 --- Comment #7 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192260&action=edit Bug 41340: Better translatability on 'batch_item_record_modification.inc' Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED CC| |catrina@bywatersolutions.co | |m --- Comment #11 from Catrina Berka <catrina@bywatersolutions.com> --- No documentation needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- + >[% tnx( '{count} item modified', '{count} items modified', modified_items_count, { count = modified_items_count }) + ' (' + tnx( 'with {count} field modified', 'with {count} fields modified', modified_fields_count, { count = modified_fields_count }) + ').' | html %]</span String concat with TT is with "_", not "+" [2026/09/30 07:56:36] [WARN] Argument " (" isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_modification.inc line 19. [2026/09/30 07:56:36] [WARN] Argument "3 items modified" isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_modification.inc line 19. [2026/09/30 07:56:36] [WARN] Argument "with 3 fields modified" isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_modification.inc line 19. [2026/09/30 07:56:36] [WARN] Argument ")." isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_modification.inc line 19. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |pedro.amorim@openfifth.co.u | |k --- Comment #13 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #12)
+ >[% tnx( '{count} item modified', '{count} items modified', modified_items_count, { count = modified_items_count }) + ' (' + tnx( 'with {count} field modified', 'with {count} fields modified', modified_fields_count, { count = modified_fields_count }) + ').' | html %]</span
String concat with TT is with "_", not "+"
[2026/09/30 07:56:36] [WARN] Argument " (" isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ batch_item_record_modification.inc line 19. [2026/09/30 07:56:36] [WARN] Argument "3 items modified" isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ batch_item_record_modification.inc line 19. [2026/09/30 07:56:36] [WARN] Argument "with 3 fields modified" isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ batch_item_record_modification.inc line 19. [2026/09/30 07:56:36] [WARN] Argument ")." isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ batch_item_record_modification.inc line 19.
Thank you Joubu, this has been pushed and backported for a while, can we please open a new bug for this? I'm removing additional_work_needed here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43786 [Bug 43786] Incorrect string concat in templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41340 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim (ammopt) from comment #13)
(In reply to Jonathan Druart from comment #12)
+ >[% tnx( '{count} item modified', '{count} items modified', modified_items_count, { count = modified_items_count }) + ' (' + tnx( 'with {count} field modified', 'with {count} fields modified', modified_fields_count, { count = modified_fields_count }) + ').' | html %]</span
String concat with TT is with "_", not "+"
[2026/09/30 07:56:36] [WARN] Argument " (" isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ batch_item_record_modification.inc line 19. [2026/09/30 07:56:36] [WARN] Argument "3 items modified" isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ batch_item_record_modification.inc line 19. [2026/09/30 07:56:36] [WARN] Argument "with 3 fields modified" isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ batch_item_record_modification.inc line 19. [2026/09/30 07:56:36] [WARN] Argument ")." isn't numeric in addition (+) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ batch_item_record_modification.inc line 19.
Thank you Joubu, this has been pushed and backported for a while, can we please open a new bug for this? I'm removing additional_work_needed here.
Most of the time follow-up bug reports are ignored, so it's extra time lost for me... Opened bug 41340. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org