[Bug 23584] New: Add public routes to change privacy settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Bug ID: 23584 Summary: Add public routes to change privacy settings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com They would substitute the following svc CGI scripts: - show_checkouts_to_relatives - show_fines_to_relatives -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED URL| |https://wiki.koha-community | |.org/wiki/Public_patrons_pr | |ivacy_endpoints_RFC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92838&action=edit Bug 23584: Add spec for PUT /public/patron/:patron_id/guarantors Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92839&action=edit Bug 23584: Add the controller method and tests This patchset adds endpoints for the patrons to change their privacy settings regarding their guarantors. The following endpoints are added: PUT /public/patrons/:patron_id/guarantors/can_see_charges PUT /public/patrons/:patron_id/guarantors/can_see_checkouts They can only be used by the patron themselves with valid sessions. And enforce the AllowPatronToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor system preferences when required. All this is covered by unit tests. To test: 1) Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io, | |josef.moravec@gmail.com, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20691 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 [Bug 23623] Use the new API and remove /svc scripts for privacy settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92839|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92840&action=edit Bug 23584: Add the controller method and tests This patchset adds endpoints for the patrons to change their privacy settings regarding their guarantors. The following endpoints are added: PUT /public/patrons/:patron_id/guarantors/can_see_charges PUT /public/patrons/:patron_id/guarantors/can_see_checkouts They can only be used by the patron themselves with valid sessions. And enforce the AllowPatronToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor system preferences when required. All this is covered by unit tests. To test: 1) Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92838|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 92911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92911&action=edit Bug 23584: Add spec for PUT /public/patron/:patron_id/guarantors Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92840|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 92912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92912&action=edit Bug 23584: Add the controller method and tests This patchset adds endpoints for the patrons to change their privacy settings regarding their guarantors. The following endpoints are added: PUT /public/patrons/:patron_id/guarantors/can_see_charges PUT /public/patrons/:patron_id/guarantors/can_see_checkouts They can only be used by the patron themselves with valid sessions. And enforce the AllowPatronToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor system preferences when required. All this is covered by unit tests. To test: 1) Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92911|0 |1 is obsolete| | Attachment #92912|0 |1 is obsolete| | --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 92990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92990&action=edit Bug 23584: Add spec for PUT /public/patron/:patron_id/guarantors Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 --- Comment #7 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 92991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92991&action=edit Bug 23584: Add the controller method and tests This patchset adds endpoints for the patrons to change their privacy settings regarding their guarantors. The following endpoints are added: PUT /public/patrons/:patron_id/guarantors/can_see_charges PUT /public/patrons/:patron_id/guarantors/can_see_checkouts They can only be used by the patron themselves with valid sessions. And enforce the AllowPatronToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor system preferences when required. All this is covered by unit tests. To test: 1) Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20691 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add public routes to change |Add public API routes to |privacy settings |change privacy settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Bug 23584 depends on bug 20691, which changed state. Bug 20691 Summary: Add ability for guarantors to view guarantee's fines in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org