[Bug 23623] New: Use the new API and remove /svc scripts for privacy settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Bug ID: 23623 Summary: Use the new API and remove /svc scripts for privacy settings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |20691, 23584 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 [Bug 23584] Add public routes to change privacy settings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92842&action=edit Bug 23623: Use the new API for changing privacy settings (guarantors) This patchset makes opac-memberentry.pl use the API instead of the old svc scripts for ajax calls, for setting privacy configuration in the OPAC. To test: 1) Disable OPACPrivacy 2) Enable AllowPatronToSetCheckoutsVisibilityForGuarantor 3) Enable AllowPatronToSetFinesVisibilityForGuarantor 4) Have a known patron be the guarantee of someone (so things display) 5) Log into the OPAC, go to the 'your personal details' tab 6) Change 'Allow your guarantor to view your current checkouts?' and click the 'Update' button. => SUCCESS: Operation succeeds 7) Reload the tab => SUCCESS: The page reflects the expected changes (i.e. the API did it right) 8) Repeat 6 and 7 with the 'Allow your guarantor to view your current fines?' option => SUCCESS: It works as well - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92843&action=edit Bug 23623: Remove the svc/patron/show* scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92842|0 |1 is obsolete| | Attachment #92843|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 92914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92914&action=edit Bug 23623: Use the new API for changing privacy settings (guarantors) This patchset makes opac-memberentry.pl use the API instead of the old svc scripts for ajax calls, for setting privacy configuration in the OPAC. To test: 1) Disable OPACPrivacy 2) Enable AllowPatronToSetCheckoutsVisibilityForGuarantor 3) Enable AllowPatronToSetFinesVisibilityForGuarantor 4) Have a known patron be the guarantee of someone (so things display) 5) Log into the OPAC, go to the 'your personal details' tab 6) Change 'Allow your guarantor to view your current checkouts?' and click the 'Update' button. => SUCCESS: Operation succeeds 7) Reload the tab => SUCCESS: The page reflects the expected changes (i.e. the API did it right) 8) Repeat 6 and 7 with the 'Allow your guarantor to view your current fines?' option => SUCCESS: It works as well - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 92915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92915&action=edit Bug 23623: Remove the svc/patron/show* scripts Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 92916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92916&action=edit Bug 23623: (follow-up) Add missing comma in ajax call definition Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 92917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92917&action=edit Bug 23623: (follow-up) Add missing filters Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92914|0 |1 is obsolete| | Attachment #92915|0 |1 is obsolete| | Attachment #92916|0 |1 is obsolete| | Attachment #92917|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 93001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93001&action=edit Bug 23623: Use the new API for changing privacy settings (guarantors) This patchset makes opac-memberentry.pl use the API instead of the old svc scripts for ajax calls, for setting privacy configuration in the OPAC. To test: 1) Disable OPACPrivacy 2) Enable AllowPatronToSetCheckoutsVisibilityForGuarantor 3) Enable AllowPatronToSetFinesVisibilityForGuarantor 4) Have a known patron be the guarantee of someone (so things display) 5) Log into the OPAC, go to the 'your personal details' tab 6) Change 'Allow your guarantor to view your current checkouts?' and click the 'Update' button. => SUCCESS: Operation succeeds 7) Reload the tab => SUCCESS: The page reflects the expected changes (i.e. the API did it right) 8) Repeat 6 and 7 with the 'Allow your guarantor to view your current fines?' option => SUCCESS: It works as well - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 93002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93002&action=edit Bug 23623: Remove the svc/patron/show* scripts Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 93003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93003&action=edit Bug 23623: (follow-up) Add missing comma in ajax call definition Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 93004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93004&action=edit Bug 23623: (follow-up) Add missing filters Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- First use of the REST API in an opac script/template ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Bug 23623 depends on bug 20691, which changed state. Bug 20691 Summary: Add ability for guarantors to view guarantee's fines in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org