[Bug 36453] New: BlockExpiredPatronOpacActions should allow multiple actions options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Bug ID: 36453 Summary: BlockExpiredPatronOpacActions should allow multiple actions options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Blocks: 34597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597 [Bug 34597] Expired patrons can still place ILL requests through OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164042&action=edit Bug 36453: DB and data changes - kohastructure.sql updates - atomicupdate file - Mandatory data installer updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164043&action=edit Bug 36453: [DO NOT PUSH] DBIC schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164044&action=edit Bug 36453: effective_BlockExpiredPatronOpacActions_contains method effective_BlockExpiredPatronOpacActions is now effective_BlockExpiredPatronOpacActions_contains This method has been updated to now consider an action param. Returns true if the given action is to be blocked to expired patrons or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164045&action=edit Bug 36453: Update old occurrences of effective_BlockExpiredPatronOpacActions Check for 'renew' when appropriate Check for 'hold' when appropriate The following command must return nothing before this is pushed to master: git grep "\beffective_BlockExpiredPatronOpacActions\b" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164046&action=edit Bug 36453: Categories admin page: Account for multiple values param Input is now multipleselect select JavaScript Staff CSS updates to account for multiselect dropdown in categories admin page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164047&action=edit Bug 36453: BlockExpiredPatronOpacActions system preference The sys pref now allows multipleselect values instead of YesNo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164048&action=edit Bug 36453: Update tests Address new new version of system pref Address new version of categories DB table BlockExpiredPatronOpacActions column Test plan, k-t-d, BEFORE applying patch: 1) Edit some patron categories, visit: /cgi-bin/koha/admin/categories.pl 2) Set different values for the "Block expired patrons" input config Set a category to block Set a category to don't block Set a category to follow the syspref 3) Take note of the current value of the BlockExpiredPatronOpacActions sys pref Apply patch, then run the following commands - koha-plack --restart kohadev - yarn css:build - run updatedatabase 4) Visit the patron categories you edited before, make sure they all have the correct values for the new config type 5) Check the BlockExpiredPatronOpacActions sys pref and make sure the new value is correct according to what was before 6) Add a new patron of one of the above categories, test that: If 'hold' is a blocked action, patron is unable to place a hold in OPAC If 'renew' is a blocked action, patron is unable to renew in OPAC If 'follow sys pref' is the option, check that a patron may place a hold or renew an item according to the BlockExpiredPatronOpacActions sys pref value prove t/db_dependent/Circulation.t prove t/db_dependent/ILSDI_Services.t prove t/db_dependent/Koha/Object.t prove t/db_dependent/Koha/Patron/Categories.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- The following command must return nothing before this is pushed to master: git grep "\beffective_BlockExpiredPatronOpacActions\b" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- 2cents : The "specific action" label on patrons category configuration is a bit ambiguous. I wouldn't know if the selected actions are the blocked ones or allowed ones. Might be better to call that "block specific actions". Also the input field seems to have a slight CSS issue, it's not wide enough so we can read the selected value without clicking on it. Tried both Firefox and Chromium with same results. Choosing "Follow system preferences" make it wider than both of the other choices which is a bit weird but not much annoying actually. Also, since the syspref is changed, the "comment" or label of the syspref makes no sense anymore. Used to be "[block|don't block] expired patrons from blablabla" Should now be something like "decide which actions are blocked for expired patrons" tried with a patron the different values from the syspref, works. the values from the category do actually override the syspref, works. a couple of very small cosmetic things could be enhanced but still signing off because the functionality just works fine and is great :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164042|0 |1 is obsolete| | Attachment #164043|0 |1 is obsolete| | Attachment #164044|0 |1 is obsolete| | Attachment #164045|0 |1 is obsolete| | Attachment #164046|0 |1 is obsolete| | Attachment #164047|0 |1 is obsolete| | Attachment #164048|0 |1 is obsolete| | --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 164762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164762&action=edit Bug 36453: DB and data changes - kohastructure.sql updates - atomicupdate file - Mandatory data installer updates Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 164763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164763&action=edit Bug 36453: [DO NOT PUSH] DBIC schema files Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 164764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164764&action=edit Bug 36453: effective_BlockExpiredPatronOpacActions_contains method effective_BlockExpiredPatronOpacActions is now effective_BlockExpiredPatronOpacActions_contains This method has been updated to now consider an action param. Returns true if the given action is to be blocked to expired patrons or not. Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 164765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164765&action=edit Bug 36453: Update old occurrences of effective_BlockExpiredPatronOpacActions Check for 'renew' when appropriate Check for 'hold' when appropriate The following command must return nothing before this is pushed to master: git grep "\beffective_BlockExpiredPatronOpacActions\b" Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #14 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 164766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164766&action=edit Bug 36453: Categories admin page: Account for multiple values param Input is now multipleselect select JavaScript Staff CSS updates to account for multiselect dropdown in categories admin page Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 164767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164767&action=edit Bug 36453: BlockExpiredPatronOpacActions system preference The sys pref now allows multipleselect values instead of YesNo Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 164768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164768&action=edit Bug 36453: Update tests Address new new version of system pref Address new version of categories DB table BlockExpiredPatronOpacActions column Test plan, k-t-d, BEFORE applying patch: 1) Edit some patron categories, visit: /cgi-bin/koha/admin/categories.pl 2) Set different values for the "Block expired patrons" input config Set a category to block Set a category to don't block Set a category to follow the syspref 3) Take note of the current value of the BlockExpiredPatronOpacActions sys pref Apply patch, then run the following commands - koha-plack --restart kohadev - yarn css:build - run updatedatabase 4) Visit the patron categories you edited before, make sure they all have the correct values for the new config type 5) Check the BlockExpiredPatronOpacActions sys pref and make sure the new value is correct according to what was before 6) Add a new patron of one of the above categories, test that: If 'hold' is a blocked action, patron is unable to place a hold in OPAC If 'renew' is a blocked action, patron is unable to renew in OPAC If 'follow sys pref' is the option, check that a patron may place a hold or renew an item according to the BlockExpiredPatronOpacActions sys pref value prove t/db_dependent/Circulation.t prove t/db_dependent/ILSDI_Services.t prove t/db_dependent/Koha/Object.t prove t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165413&action=edit Bug 36453: (QA follow-up): Cosmetic fixes This is a squash of several improvements: - Override weird blue color being applied from MultipleSelect when all options from an optgroup are selected; - Fix input width depending on selected value. Now it should always be same width regardless; - Updated the system preference wording to reflect updated behavior; - Updated UI labels in the patron category edit page to enforce that the actions being selected are "actions to be blocked" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Thank you Arthur for testing and your review. I agree with all your comments and I have followed up on the QA follow-up patch. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165413|0 |1 is obsolete| | --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165414&action=edit Bug 36453: (QA follow-up): Cosmetic fixes This is a squash of several improvements: - Override weird blue color being applied from MultipleSelect when all options from an optgroup are selected; - Fix input width depending on selected value. Now it should always be same width regardless; - Updated the system preference UI wording to reflect new behavior; - Updated UI labels in the patron category edit page to enforce that the actions being selected are "actions to be blocked" - Corrected sysprefs.sql entry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26297 --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Adding bug 26297 as a dependency. Work here needs to update BlockExpiredPatronOpacActions in the patron categories REST API spec added by bug 26297. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 [Bug 26297] Add a route to list patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165454&action=edit Bug 36453: (QA follow-up): Update api spec Access {staff_url}/api/v1/patron_categories and notice all is as expected Update some patron category's blocked expired patron OPAC actions and access the endpoint again, notice it's okay. Updated API tests to include to_api confirming attributes are rendered correctly: prove t/db_dependent/api/v1/patron_categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164762|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167461&action=edit Bug 36453: DB and data changes - kohastructure.sql updates - atomicupdate file - Mandatory data installer updates Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164763|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167462&action=edit Bug 36453: [DO NOT PUSH] DBIC schema files Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164764|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167463&action=edit Bug 36453: effective_BlockExpiredPatronOpacActions_contains method effective_BlockExpiredPatronOpacActions is now effective_BlockExpiredPatronOpacActions_contains This method has been updated to now consider an action param. Returns true if the given action is to be blocked to expired patrons or not. Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164765|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167464&action=edit Bug 36453: Update old occurrences of effective_BlockExpiredPatronOpacActions Check for 'renew' when appropriate Check for 'hold' when appropriate The following command must return nothing before this is pushed to master: git grep "\beffective_BlockExpiredPatronOpacActions\b" Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164766|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167465&action=edit Bug 36453: Categories admin page: Account for multiple values param Input is now multipleselect select JavaScript Staff CSS updates to account for multiselect dropdown in categories admin page Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164767|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167466&action=edit Bug 36453: BlockExpiredPatronOpacActions system preference The sys pref now allows multipleselect values instead of YesNo Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164768|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167467&action=edit Bug 36453: Update tests Address new new version of system pref Address new version of categories DB table BlockExpiredPatronOpacActions column Test plan, k-t-d, BEFORE applying patch: 1) Edit some patron categories, visit: /cgi-bin/koha/admin/categories.pl 2) Set different values for the "Block expired patrons" input config Set a category to block Set a category to don't block Set a category to follow the syspref 3) Take note of the current value of the BlockExpiredPatronOpacActions sys pref Apply patch, then run the following commands - koha-plack --restart kohadev - yarn css:build - run updatedatabase 4) Visit the patron categories you edited before, make sure they all have the correct values for the new config type 5) Check the BlockExpiredPatronOpacActions sys pref and make sure the new value is correct according to what was before 6) Add a new patron of one of the above categories, test that: If 'hold' is a blocked action, patron is unable to place a hold in OPAC If 'renew' is a blocked action, patron is unable to renew in OPAC If 'follow sys pref' is the option, check that a patron may place a hold or renew an item according to the BlockExpiredPatronOpacActions sys pref value prove t/db_dependent/Circulation.t prove t/db_dependent/ILSDI_Services.t prove t/db_dependent/Koha/Object.t prove t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165414|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167468&action=edit Bug 36453: (QA follow-up): Cosmetic fixes This is a squash of several improvements: - Override weird blue color being applied from MultipleSelect when all options from an optgroup are selected; - Fix input width depending on selected value. Now it should always be same width regardless; - Updated the system preference UI wording to reflect new behavior; - Updated UI labels in the patron category edit page to enforce that the actions being selected are "actions to be blocked" - Corrected sysprefs.sql entry Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165454|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167469&action=edit Bug 36453: (QA follow-up): Update api spec Access {staff_url}/api/v1/patron_categories and notice all is as expected Update some patron category's blocked expired patron OPAC actions and access the endpoint again, notice it's okay. Updated API tests to include to_api confirming attributes are rendered correctly: prove t/db_dependent/api/v1/patron_categories Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167470&action=edit Bug 36453: (QA follow-up) Modernise database update This patch adds the colored output expected for 24.11.x onward database updates. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167461|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167471&action=edit Bug 36453: DB and data changes - kohastructure.sql updates - atomicupdate file - Mandatory data installer updates Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167462|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167472&action=edit Bug 36453: [DO NOT PUSH] DBIC schema files Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167463|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167473&action=edit Bug 36453: effective_BlockExpiredPatronOpacActions_contains method effective_BlockExpiredPatronOpacActions is now effective_BlockExpiredPatronOpacActions_contains This method has been updated to now consider an action param. Returns true if the given action is to be blocked to expired patrons or not. Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167464|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167474&action=edit Bug 36453: Update old occurrences of effective_BlockExpiredPatronOpacActions Check for 'renew' when appropriate Check for 'hold' when appropriate The following command must return nothing before this is pushed to master: git grep "\beffective_BlockExpiredPatronOpacActions\b" Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167465|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167475&action=edit Bug 36453: Categories admin page: Account for multiple values param Input is now multipleselect select JavaScript Staff CSS updates to account for multiselect dropdown in categories admin page Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167466|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167476&action=edit Bug 36453: BlockExpiredPatronOpacActions system preference The sys pref now allows multipleselect values instead of YesNo Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167467|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167477&action=edit Bug 36453: Update tests Address new new version of system pref Address new version of categories DB table BlockExpiredPatronOpacActions column Test plan, k-t-d, BEFORE applying patch: 1) Edit some patron categories, visit: /cgi-bin/koha/admin/categories.pl 2) Set different values for the "Block expired patrons" input config Set a category to block Set a category to don't block Set a category to follow the syspref 3) Take note of the current value of the BlockExpiredPatronOpacActions sys pref Apply patch, then run the following commands - koha-plack --restart kohadev - yarn css:build - run updatedatabase 4) Visit the patron categories you edited before, make sure they all have the correct values for the new config type 5) Check the BlockExpiredPatronOpacActions sys pref and make sure the new value is correct according to what was before 6) Add a new patron of one of the above categories, test that: If 'hold' is a blocked action, patron is unable to place a hold in OPAC If 'renew' is a blocked action, patron is unable to renew in OPAC If 'follow sys pref' is the option, check that a patron may place a hold or renew an item according to the BlockExpiredPatronOpacActions sys pref value prove t/db_dependent/Circulation.t prove t/db_dependent/ILSDI_Services.t prove t/db_dependent/Koha/Object.t prove t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167478&action=edit Bug 36453: (QA follow-up) Cosmetic fixes This is a squash of several improvements: - Override weird blue color being applied from MultipleSelect when all options from an optgroup are selected; - Fix input width depending on selected value. Now it should always be same width regardless; - Updated the system preference UI wording to reflect new behavior; - Updated UI labels in the patron category edit page to enforce that the actions being selected are "actions to be blocked" - Corrected sysprefs.sql entry Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167479&action=edit Bug 36453: (QA follow-up) Update api spec Access {staff_url}/api/v1/patron_categories and notice all is as expected Update some patron category's blocked expired patron OPAC actions and access the endpoint again, notice it's okay. Updated API tests to include to_api confirming attributes are rendered correctly: prove t/db_dependent/api/v1/patron_categories Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167470|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167480&action=edit Bug 36453: (QA follow-up) Modernise database update This patch adds the colored output expected for 24.11.x onward database updates. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167468|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167469|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work.. whilst the method name is a little scary I'm happy this is already a big improvement and I couldn't come up with a better name. Down the line I'd love to see more cleanup like the two methods in Patron::Category merged and the method name somehow clarified/reduced... Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi all. This broke MySQL 8 support, as it is setting a default value for a MEDIUM column, which is not allowed. Steps to reproduce: ```shell ktd down DB_IMAGE=mysql:8.0 ktd up ``` and you get: ``` C4::Installer::load_sql returned the following errors while attempting to load /kohadevbox/koha/installer/data/mysql/kohastructure.sql: DBD::mysql::st execute failed: BLOB, TEXT, GEOMETRY or JSON column 'BlockExpiredPatronOpacActions' can't have a default value at /usr/share/perl5/DBIx/RunSQL.pm line 290, <$args{...}> line 1. Something went wrong loading file /kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE TABLE `categories` ( ... ``` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #45 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #44)
Hi all. This broke MySQL 8 support, as it is setting a default value for a MEDIUM column, which is not allowed.
I propose we change it to NULL, and make the code take NULL => follow_syspref_BlockExpiredPatronOpacActions behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could also reconsider the datatype? Not sure what datatype would allow defaults, but since we only want to store a few things we do probably have a lot of other options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #47 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Can try and test this in a bit, can't remember why the choice for mediumtext but I wonder if just changing it to varchar(255) would fix the issue? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #48 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168435&action=edit Bug 36453: (QA follow-up) Address upgraded instances To test: 1) Apply only this patch, skipping the next one (patch 'Use varchar instead of mediumtext') 2) Run ktd up with default DBMS mariadb:10.5: ktd up 3) Confirm the database state is wrong: DESC categories BlockExpiredPatronOpacActions; ^ This should return type = mediumtext 4) Run updatedatabase, make sure green success message shows Running the above query again will show type = varchar(128) 5) Run updatedatabase again, notice blue info message notifies its already varchar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #49 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168436&action=edit Bug 36453: (QA follow-up) Use varchar instead of mediumtext Test plan: 1) ktd down 2) DB_IMAGE=mysql:8.0 ktd up 3) Should now work with no issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Bug 36453 depends on bug 26297, which changed state. Bug 26297 Summary: Add a route to list patron categories https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please switch back to PQA when a follow-up is added - this way I can't miss it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we might have got away with changing the kohastructure and the first database update, as noone should be running on main... but this of course is the safest way of doing it. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed follow-up patches to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #53 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #50)
Please switch back to PQA when a follow-up is added - this way I can't miss it :)
Ooops. (In reply to Katrin Fischer from comment #51)
I think we might have got away with changing the kohastructure and the first database update, as noone should be running on main... but this of course is the safest way of doing it. :)
Agreed. But I think the additional atomic update covers all our basis and further helps ensure this does not come up again for anyone. Removed 'additional_work_needed'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #54 from Lucas Gass <lucas@bywatersolutions.com> --- This seems like an enhancement to me and I'm reluctant to backport it to 24.05.x. Feel free to tell me I'm wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Multiple database changes and also some failing tests we need to look into - not for backporting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #56 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #55)
Multiple database changes and also some failing tests we need to look into - not for backporting.
Agreed. What tests are failing as a result of this? Let me know, I'll find the time to look into it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Text to go in the| |This enhancement improves release notes| |the | |BlockExpiredPatronOpacActio | |ns system preference to | |allow the specification of | |which OPAC actions are | |blocked for expired | |patrons. | |Prior to this | |enhancement, this system | |preference functioned as a | |simple "on" or "off" | |switch, where having it | |'on' blocked both 'placing | |holds' and 'renewing an | |item' for expired patrons | |on the OPAC. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #57 from Jonathan Druart <jonathan.druart@gmail.com> --- .js file is using _("") when __("") must be used. I am suspecting some strings to not be picked by the translation script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38492 Keywords|additional_work_needed | --- Comment #58 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #57)
.js file is using _("") when __("") must be used. I am suspecting some strings to not be picked by the translation script.
Opened bug 38492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 [Bug 38492] Some javascript translatable strings do not get picked up for translation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1006 Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40126 [Bug 40126] Typo in "# of % selected"? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org