[Bug 13235] New: Revise layout of patron search form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Bug ID: 13235 Summary: Revise layout of patron search form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 10153 changed the layout of the patron search form so that expanded search fields would be stacked (http://www.screencast.com/t/LnVgH2nV) rather than in one line (http://www.screencast.com/t/t0XkqsSX). Bug 9811 returned the layout to a non-stacked layout (http://www.screencast.com/t/9Cn8B0VKm6q), but I think this was not done as an intentional override of Bug 10153. I think the patch was based on the previous version. I propose to bring back the stacked version. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I liked the non-stacked, especially since German words are often longer than the english ones and the stacked layout gives more flexiblity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33502&action=edit Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #0)
Bug 9811 returned the layout to a non-stacked layout (http://www.screencast.com/t/9Cn8B0VKm6q), but I think this was not done as an intentional override of Bug 10153. I think the patch was based on the previous version.
Yes completely, sorry about that. (In reply to Katrin Fischer from comment #1)
I liked the non-stacked, especially since German words are often longer than the english ones and the stacked layout gives more flexiblity.
So you prefer the stacked or the non-stacked version? :) Could you rebase this patch please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah right, the stacked! Every option on its own line :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33502|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 34073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34073&action=edit Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34073|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34084&action=edit Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34085&action=edit Bug 13235: Move onclick attr to javacsript code Refactor 1 line of code and add a preventDefault. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34084|0 |1 is obsolete| | Attachment #34085|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34153&action=edit [PASSED QA] Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34154&action=edit [PASSED QA] Bug 13235: Move onclick attr to javacsript code Refactor 1 line of code and add a preventDefault. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34153|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 35472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35472&action=edit [PASSED QA] [Rebased] Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34154|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 35473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35473&action=edit [PASSED QA] Bug 13235: Move onclick attr to javacsript code Refactor 1 line of code and add a preventDefault. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- I have rebased my patch and re-attached the follow-up so that they are in the right order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Hmm this doesnt apply on 3.18.x .. if you think it should be on there, could you please rebase it for that. Thanks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org