[Bug 9472] New: subfields in order when cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Bug ID: 9472 Summary: subfields in order when cataloging Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: nengard@gmail.com CC: m.de.rooy@rijksmuseum.nl When clicking "Edit Record" if a subfield doesn't have data the subfields are out of order. For example, the subfields are showing as 'a,' then 'c' because those two had data in them, and then the rest of the empty subfields were listed below those two in alphabetical order. It would be nice if the subfields were displayed in alphabetical order in record editing mode regardless of whether the subfields have data in them or not (so subfield 'b' should be in there). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37569&action=edit Bug 9472: Order subfields alphabeticaly when cataloging On cataloging a record, the subfields without data were put at the end of the other subfields. This patch orders the subfields alphabeticaly even if they don't containt any data. Test plan: 1/ Edit a record with some subfields without any data => The subfield should not be visible (maybe they are if they are mandatory). 2/ Click on a tag to expand the subfield list. 3/ The subfields should be ordered alphabaticaly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal Patch complexity|--- |Small patch Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I have only glanced at your solution, but if this is a general sort of all subfields, it is not the right solution. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #2)
I have only glanced at your solution, but if this is a general sort of all subfields, it is not the right solution.
Sort of all subfields for a tag, and not for all tags. What is the right solution if this is not the one? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
Sort of all subfields for a tag, and not for all tags. What is the right solution if this is not the one?
Good question :) I am not aware of UNIMARC specifics here, but in MARC21 there are quite some fields with constructions like this: 100a - 100q - 100d The order should not be alphabetical by default and for all tags. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #4)
(In reply to Jonathan Druart from comment #3)
Sort of all subfields for a tag, and not for all tags. What is the right solution if this is not the one?
Good question :) I am not aware of UNIMARC specifics here, but in MARC21 there are quite some fields with constructions like this: 100a - 100q - 100d The order should not be alphabetical by default and for all tags.
Yes, I am aware of that. But actually, against master, the display is: all subfields, alphabetically sorted, present in the record followed by: all subfields, alphabetically sorted, non present in the record. (search for foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) ~ l.600-700) This patch just suggests to display all subfields, alphabetically sorted. Which makes more sense. If my dsecription of how it works on master is wrong, my patch is certainly wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5)
Yes, I am aware of that. But actually, against master, the display is: all subfields, alphabetically sorted, present in the record followed by: all subfields, alphabetically sorted, non present in the record.
(search for foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) ~ l.600-700)
This patch just suggests to display all subfields, alphabetically sorted. Which makes more sense.
If my dsecription of how it works on master is wrong, my patch is certainly wrong.
Yes, I am still afraid that your patch is actually "wrong" ;) I am not sure if you understood my point too. Hope the following clarifies: I tested this: I had a tag 100 with a 9 4 q d e (4 and e were empty) Without your patch, I look in catalogue marc detail, I see: 100 a q d. Fine! Without your patch, I look in opac marc detail, I see: 100 a 9 q d. Fine too. Now with your patch, I edit the record: The order is now: 4-9-a-d-e-q Catalogue marc detail gives: a-d-q CHANGED ! Opac marc detail: 9-a-d-q CHANGED AGAIN ! Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|jonathan.druart@biblibre.co |gmcharlt@gmail.com |m | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #6) Ok so the fields should not sorted alphabetically. In this case, the naive approach cannot work, a much more complicated patch must be provided. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Reset assignee to default. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
Reset assignee to default.
Should your patch be obsoleted too? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #9)
(In reply to Jonathan Druart from comment #8)
Reset assignee to default.
Should your patch be obsoleted too?
Yes, done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org